Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2776193002: Revert of linux: Improve gdb startup time for debug builds from over 4 minutes to 35s. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index d16acaf0c68c63729ca8be34023e51359fb1bc20..916d78a120b4e470fdebafc087f7292898ff9824 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -64,6 +64,10 @@
# We can use breakpad for these builds.
exclude_unwind_tables = (is_chrome_branded && is_official_build) ||
(is_chromecast && !is_cast_desktop_build && !is_debug)
+
+ # If true, gold linker will save symbol table inside object files.
+ # This speeds up gdb startup by 60%
+ gdb_index = false
# If true, optimize for size. Does not affect windows builds.
# Linux & Mac favor speed over size.
@@ -305,8 +309,7 @@
ldflags += [ "-fPIC" ]
}
- # Use pipes for communicating between sub-processes. Faster.
- cflags += [ "-pipe" ]
+ cflags += [ "-pipe" ] # Use pipes for communicating between sub-processes. Faster.
ldflags += [
"-Wl,-z,noexecstack",
@@ -370,6 +373,10 @@
"-Wl,--thread-count=4",
]
}
+ }
+
+ if (gdb_index) {
+ ldflags += [ "-Wl,--gdb-index" ]
}
# TODO(thestig): Make this flag work with GN.
@@ -1655,9 +1662,6 @@
}
asmflags = cflags
ldflags = []
- if (!is_mac && !is_ios && !is_nacl) {
- ldflags += [ "-Wl,--gdb-index" ]
- }
}
}
@@ -1679,8 +1683,9 @@
} else {
cflags = [ "-g1" ]
}
-
- # Note: -gsplit-dwarf implicitly turns on -g2 with clang, so don't pass it.
+ if (use_debug_fission) {
+ cflags += [ "-gsplit-dwarf" ]
+ }
asmflags = cflags
ldflags = []
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698