third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp - Issue 2776103002: Make RenderedRectsForMarkers() to ignore disconnected nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2776103002: Make RenderedRectsForMarkers() to ignore disconnected nodes. (Closed)

Patch Set: except Range Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/text-match-document-change-expected.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

index c68602d7b8cba35a2b1015d77bf2ce30479e9c26..58a16979c7f6d064ee055e905e879b9bab5c3aa2 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

@@ -516,6 +516,8 @@ Vector<IntRect> DocumentMarkerController::RenderedRectsForMarkers(

node_iterator != end; ++node_iterator) {

// inner loop; process each marker in this node

const Node& node = *node_iterator->key;

+ if (!node.isConnected())

+ continue;

MarkerLists* markers = node_iterator->value.Get();

for (size_t marker_list_index = 0;

marker_list_index < DocumentMarker::kMarkerTypeIndexesCount;