Make RenderedRectsForMarkers() to ignore disconnected nodes.

third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
index f1da75b0e408206c7b87a6ce891b67ed7c7005fc..6bd6dba51accc3fb5143b4ade974989dd9b16896 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
@@ -4048,4 +4048,43 @@ PositionInFlatTree skipWhitespace(const PositionInFlatTree& position) {
   return skipWhitespaceAlgorithm(position);
 }
 
+template <typename Strategy>
+Vector<IntRect> computeTextRects(

[yosin_UTC9, 2017/04/06 04:26:04]

In this patch, please do this change in "Range.cpp" rather than moving to
"VisibleUnits.cpp" for
ease of tracking change of Range to EphemeralRange.

In other words, this patch should be change Range.cpp only. Following patches
will
 1. Move computeTextRects() to "VisibleUnits.cpp"
 2. Change call sites to use computeTextRects()

Also, we don't expect behavior changes by this effort, since this is just
re-factoring.

+    const EphemeralRangeTemplate<Strategy>& range) {
+  const PositionTemplate<Strategy> startPosition = range.startPosition();
+  const PositionTemplate<Strategy> endPosition = range.endPosition();
+  Node* startContainer = startPosition.computeContainerNode();
+  DCHECK(startContainer);
+  Node* endContainer = endPosition.computeContainerNode();
+  DCHECK(endContainer);
+  Vector<IntRect> rects;
+  for (Node& node : range.nodes()) {
+    LayoutObject* layoutObject = node.layoutObject();
+    if (!layoutObject || !layoutObject->isText())
+      continue;
+    LayoutText* layoutText = toLayoutText(layoutObject);
+    unsigned startOffset =
+        node == startContainer ? startPosition.offsetInContainerNode() : 0;
+    unsigned endOffset = node == endContainer
+                             ? endPosition.offsetInContainerNode()
+                             : std::numeric_limits<unsigned>::max();
+    layoutText->absoluteRectsForRange(rects, startOffset, endOffset);
+  }
+  return rects;
+}
+
+IntRect computeBoundingBox(const EphemeralRange& range) {
+  IntRect result;
+  for (const IntRect& rect : computeTextRects(range))
+    result.unite(rect);
+  return result;
+}
+
+IntRect computeBoundingBox(const EphemeralRangeInFlatTree& range) {
+  IntRect result;
+  for (const IntRect& rect : computeTextRects(range))
+    result.unite(rect);
+  return result;
+}
+
 }  // namespace blink