ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.h - Issue 2776083003: Use correct snapshot for the tab transition animation on iPad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.h

Issue 2776083003: Use correct snapshot for the tab transition animation on iPad (Closed)

Patch Set: Formatting and other feedback Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm ('K') | « ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm ('k') | ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.h

diff --git a/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.h b/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.h

index 4f1baf1dbe4a85ff47ab886580d156d6e7c7d123..620ff71a9641beb78b77a174bb3140ab895f0ac9 100644

--- a/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.h

+++ b/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.h

@@ -27,9 +27,10 @@

// Holds a snapshot view of the browser view controller's toolbar.

@property(nonatomic, retain) UIView* toolbarSnapshotView;

-// Index of the selected tab in the browser view controller when the transition

-// context content was created.

-@property(nonatomic, assign) NSInteger initialSelectedTabIndex;

+// The tabID that was in the browser view controller when the transition context

+// content was created. Used to understand what might have changed in the model

+// when entering and leaving the tab switcher.

+@property(nonatomic, retain) NSString* initialTabID;

jif 2017/03/30 19:50:58 Can you copy the NSString instead of retaining it?

@end

// A Tab switcher transition context holds the informations needed to compute