Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2776073004: Add removal date to ::shadow and /deep/ (Closed)
Patch Set: wip Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 068e5302b53cff9ce45ed0fae2223e734255b6da..5187a91aa3aa52d0545c7ed54e52e3ee1f15efaa 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -364,14 +364,14 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature) {
"details.";
case UseCounter::CSSDeepCombinator:
- return "/deep/ combinator is deprecated. See "
- "https://www.chromestatus.com/features/6750456638341120 for more "
- "details.";
+ return String::format(
+ "/deep/ combinator is deprecated and will be a no-op in %s. See "
+ "https://www.chromestatus.com/features/4964279606312960 for more "
+ "details.",
+ milestoneString(M60));
case UseCounter::CSSSelectorPseudoShadow:
- return "::shadow pseudo-element is deprecated. See "
- "https://www.chromestatus.com/features/6750456638341120 for more "
- "details.";
+ return willBeRemoved("::shadow pseudo-element", M60, "6750456638341120");
case UseCounter::VRDeprecatedFieldOfView:
return replacedBy("VREyeParameters.fieldOfView",
@@ -409,7 +409,8 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature) {
"Web Crypto API usage inside secure frames with non-secure ancestors "
"is deprecated. The API will no longer be exposed in these contexts "
"as of %s. See https://www.chromestatus.com/features/5030265697075200"
- " for more details.", milestoneString(M59));
+ " for more details.",
+ milestoneString(M59));
case UseCounter::RtcpMuxPolicyNegotiate:
return String::format(
« no previous file with comments | « third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698