Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2776073003: Log created probe clusters to RtcEventLog. (Closed)

Created:
3 years, 8 months ago by philipel
Modified:
3 years, 8 months ago
Reviewers:
terelius, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Log created probe clusters to RtcEventLog. BUG=webrtc:6984 Review-Url: https://codereview.webrtc.org/2776073003 Cr-Commit-Position: refs/heads/master@{#17413} Committed: https://chromium.googlesource.com/external/webrtc/+/bb9e6edc327bb2aa03fdc3b480925727d9831f9e

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -14 lines) Patch
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/pacing/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/pacing/bitrate_prober.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/pacing/bitrate_prober.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/mock/mock_paced_sender.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
philipel
3 years, 8 months ago (2017-03-27 16:20:22 UTC) #2
terelius
https://codereview.webrtc.org/2776073003/diff/20001/webrtc/logging/rtc_event_log/DEPS File webrtc/logging/rtc_event_log/DEPS (right): https://codereview.webrtc.org/2776073003/diff/20001/webrtc/logging/rtc_event_log/DEPS#newcode5 webrtc/logging/rtc_event_log/DEPS:5: "+webrtc/modules/pacing", Do you really have to change this? Isn't ...
3 years, 8 months ago (2017-03-27 17:08:11 UTC) #7
philipel
https://codereview.webrtc.org/2776073003/diff/20001/webrtc/logging/rtc_event_log/DEPS File webrtc/logging/rtc_event_log/DEPS (right): https://codereview.webrtc.org/2776073003/diff/20001/webrtc/logging/rtc_event_log/DEPS#newcode5 webrtc/logging/rtc_event_log/DEPS:5: "+webrtc/modules/pacing", On 2017/03/27 17:08:11, terelius wrote: > Do you ...
3 years, 8 months ago (2017-03-28 08:50:24 UTC) #12
terelius
lgtm
3 years, 8 months ago (2017-03-28 10:44:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2776073003/40001
3 years, 8 months ago (2017-03-28 10:47:21 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/bb9e6edc327bb2aa03fdc3b480925727d9831f9e
3 years, 8 months ago (2017-03-28 11:12:33 UTC) #18
philipel
3 years, 8 months ago (2017-03-28 11:20:46 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2775273003/ by philipel@webrtc.org.

The reason for reverting is: Break build bots..

Powered by Google App Engine
This is Rietveld 408576698