Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

Issue 2776073002: Workaround for Samsung email issues (Closed)
Patch Set: add a test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
index 66779333e88e2b0175f4f0dcb441510308e16486..7d45271f971acaa7162e295e97ab1102af6a2fc3 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
@@ -174,11 +174,15 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
final boolean allowGeolocationOnInsecureOrigins =
mAppTargetSdkVersion <= Build.VERSION_CODES.M;
+ // https://crbug.com/698752
+ final boolean doNotUpdateSelectionOnMutatingSelectionRange =
+ mAppTargetSdkVersion <= Build.VERSION_CODES.M;
+
mContentsClientAdapter = mFactory.createWebViewContentsClientAdapter(mWebView, mContext);
- mWebSettings = new ContentSettingsAdapter(
- new AwSettings(mContext, isAccessFromFileURLsGrantedByDefault,
- areLegacyQuirksEnabled, allowEmptyDocumentPersistence,
- allowGeolocationOnInsecureOrigins));
+ mWebSettings = new ContentSettingsAdapter(new AwSettings(mContext,
+ isAccessFromFileURLsGrantedByDefault, areLegacyQuirksEnabled,
+ allowEmptyDocumentPersistence, allowGeolocationOnInsecureOrigins,
+ doNotUpdateSelectionOnMutatingSelectionRange));
if (mAppTargetSdkVersion < Build.VERSION_CODES.LOLLIPOP) {
// Prior to Lollipop we always allowed third party cookies and mixed content.

Powered by Google App Engine
This is Rietveld 408576698