Workaround for Samsung email issues

android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package com.android.webview.chromium;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.content.Context;
 import android.content.Intent;
@@ skipping 156 matching lines @@
             }
         }
 
         final boolean isAccessFromFileURLsGrantedByDefault =
                 mAppTargetSdkVersion < Build.VERSION_CODES.JELLY_BEAN;
         final boolean areLegacyQuirksEnabled = mAppTargetSdkVersion < Build.VERSION_CODES.KITKAT;
         final boolean allowEmptyDocumentPersistence = mAppTargetSdkVersion <= Build.VERSION_CODES.M;
         final boolean allowGeolocationOnInsecureOrigins =
                 mAppTargetSdkVersion <= Build.VERSION_CODES.M;
 
+        final String samsungEmailPackageId = "com.samsung.android.email.provider";

[aelias_OOO_until_Jul13, 2017/03/31 23:40:21]

I don't think an APK name check is called for here.  Name-checks can cause
mysterious problems (e.g. beta channel or derivative fork behaving different
from main one) so I think they're only appropriate for particularly unsafe/crazy
hacks.  Since this is just restoring the previous behavior that we shipped
before, I think it's cleaner to make it global all WebView with low enough
targetSdkVersion.  We can see that as a slower, safer way of rolling out this
breaking change.

[Changwan Ryu, 2017/04/01 00:07:56]

Done. Also checking with Samsung about the package name variants.

+        final boolean doNotUpdateSelectionOnMutatingSelectionRange =
+                samsungEmailPackageId.equals(mContext.getPackageName())
+                && mAppTargetSdkVersion <= Build.VERSION_CODES.M;

[aelias_OOO_until_Jul13, 2017/03/31 23:25:41]

Why M and below?  I would've expected N and below.  Some Samsung devices have
already shipped N (some variants of Galaxy S7), have you checked this issue does
not repro on them?

[Changwan Ryu, 2017/03/31 23:28:10]

Sorry I wasn't super clear about this. Samsung's initial test result indicates
that this does not happen on Android N. But I'll confirm with them.

[aelias_OOO_until_Jul13, 2017/03/31 23:40:21]

OK sounds good.  Targeting M is somewhat better if we can get away with it.

+
         mContentsClientAdapter = mFactory.createWebViewContentsClientAdapter(mWebView, mContext);
-        mWebSettings = new ContentSettingsAdapter(
-                new AwSettings(mContext, isAccessFromFileURLsGrantedByDefault,
-                        areLegacyQuirksEnabled, allowEmptyDocumentPersistence,
-                        allowGeolocationOnInsecureOrigins));
+        mWebSettings = new ContentSettingsAdapter(new AwSettings(mContext,
+                isAccessFromFileURLsGrantedByDefault, areLegacyQuirksEnabled,
+                allowEmptyDocumentPersistence, allowGeolocationOnInsecureOrigins,
+                doNotUpdateSelectionOnMutatingSelectionRange));
 
         if (mAppTargetSdkVersion < Build.VERSION_CODES.LOLLIPOP) {
             // Prior to Lollipop we always allowed third party cookies and mixed content.
             mWebSettings.setMixedContentMode(WebSettings.MIXED_CONTENT_ALWAYS_ALLOW);
             mWebSettings.setAcceptThirdPartyCookies(true);
             mWebSettings.getAwSettings().setZeroLayoutHeightDisablesViewportQuirk(true);
         }
 
         if (mShouldDisableThreadChecking) disableThreadChecking();
 
@@ skipping 2081 matching lines @@
         mAwContents.extractSmartClipData(x, y, width, height);
     }
 
     // Implements SmartClipProvider
     @Override
     public void setSmartClipResultHandler(final Handler resultHandler) {
         checkThread();
         mAwContents.setSmartClipResultHandler(resultHandler);
     }
 }