Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: remoting/host/forward_process_stats_agent.h

Issue 2775983003: [Chromoting] Retrieve process resource usage (ProcessStats) and its tests (Closed)
Patch Set: Resolve review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef REMOTING_HOST_FORWARD_PROCESS_STATS_AGENT_H_
6 #define REMOTING_HOST_FORWARD_PROCESS_STATS_AGENT_H_
7
8 #include "base/synchronization/lock.h"
9 #include "remoting/host/process_stats_agent.h"
10 #include "remoting/proto/process_stats.pb.h"
11
12 namespace remoting {
13
14 // A component to forward statistic data of another process.
Sergey Ulanov 2017/04/24 18:49:11 I don't think this comment is clear and it doesn't
Hzj_jie 2017/04/25 00:17:53 Done.
15 class ForwardProcessStatsAgent final : public ProcessStatsAgent {
16 public:
17 ForwardProcessStatsAgent();
18 ~ForwardProcessStatsAgent() override;
19
20 protocol::ProcessResourceUsage GetResourceUsage() override;
21
22 void OnProcessStats(const protocol::ProcessResourceUsage& usage);
23
24 private:
25 base::Lock lock_;
Sergey Ulanov 2017/04/24 18:49:11 I don't think you need the lock. Normally all IPC
Hzj_jie 2017/04/25 00:17:53 Changed to ThreadChecker.
26 protocol::ProcessResourceUsage usage_;
27 };
28
29 } // namespace remoting
30
31 #endif // REMOTING_HOST_FORWARD_PROCESS_STATS_AGENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698