Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 277593004: Revert of Improved x86 SSE build and run-time checks. (Closed)

Created:
6 years, 7 months ago by mtklein
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Improved x86 SSE build and run-time checks. (https://codereview.chromium.org/272503006/) Reason for revert: Windows builders breaking. :( Original issue's description: > Improved x86 SSE build and run-time checks. > > Replaces the current build/run-time checks for SSE level in > opts_check_x86.cpp with a simpler and more future-proof version. > Also adds SSE versions 4.1 and 4.2 to the config file. > > Author: henrik.smiding@intel.com > > Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>; > > Committed: http://code.google.com/p/skia/source/detail?r=14644 TBR=reed@google.com,tomhudson@google.com,djsollen@google.com,joakim.landberg@intel.com,henrik.smiding@intel.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -68 lines) Patch
M include/core/SkPreConfig.h View 1 chunk +1 line, -7 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 16 chunks +70 lines, -61 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Improved x86 SSE build and run-time checks.
6 years, 7 months ago (2014-05-08 15:26:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/277593004/1
6 years, 7 months ago (2014-05-08 15:27:45 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 15:27:54 UTC) #3
Message was sent while issue was closed.
Change committed as 14646

Powered by Google App Engine
This is Rietveld 408576698