Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 277593003: Fix Moz2D build (Closed)

Created:
6 years, 7 months ago by borenet
Modified:
6 years, 7 months ago
Reviewers:
gw280, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add % #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M gyp/common_conditions.gypi View 1 1 chunk +9 lines, -0 lines 0 comments Download
M gyp/common_variables.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
borenet
6 years, 7 months ago (2014-05-08 13:49:46 UTC) #1
reed1
lgtm
6 years, 7 months ago (2014-05-08 14:57:52 UTC) #2
borenet
The CQ bit was checked by borenet@google.com
6 years, 7 months ago (2014-05-08 14:58:21 UTC) #3
reed1
I wonder if we can move this sort of guard mechanism into moz code, so ...
6 years, 7 months ago (2014-05-08 14:58:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/277593003/20001
6 years, 7 months ago (2014-05-08 14:59:33 UTC) #5
borenet
On 2014/05/08 14:58:45, reed1 wrote: > I wonder if we can move this sort of ...
6 years, 7 months ago (2014-05-08 15:00:39 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 15:30:04 UTC) #7
Message was sent while issue was closed.
Change committed as 14647

Powered by Google App Engine
This is Rietveld 408576698