Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: ios/web/navigation/navigation_manager_impl_unittest.mm

Issue 2775893003: Removed dead code from NavigationManagerImpl::GetIndexForOffset. (Closed)
Patch Set: Actually removed dead code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/navigation_manager_impl.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/navigation_manager_impl_unittest.mm
diff --git a/ios/web/navigation/navigation_manager_impl_unittest.mm b/ios/web/navigation/navigation_manager_impl_unittest.mm
index 7bac7552ab46256554b5a441339fd7f0aba2b974..ed28bf6401549fa0dd7e542a34e8f667e8d8b658 100644
--- a/ios/web/navigation/navigation_manager_impl_unittest.mm
+++ b/ios/web/navigation/navigation_manager_impl_unittest.mm
@@ -169,27 +169,6 @@ TEST_F(NavigationManagerTest, CanGoBackWithMultipleCommitedItems) {
EXPECT_TRUE(navigation_manager()->CanGoToOffset(-1));
}
-// Tests that going forward or positive offset is not possible if there is a
-// pending entry.
-TEST_F(NavigationManagerTest, CanGoForwardWithPendingItem) {
- navigation_manager()->AddPendingItem(
- GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
- [session_controller() commitPendingItem];
- navigation_manager()->AddPendingItem(
- GURL("http://www.url.com/0"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
- [session_controller() commitPendingItem];
- [session_controller() goToItemAtIndex:0];
- navigation_manager()->AddPendingItem(
- GURL("http://www.url.com/1"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
-
- // Pending entry should not allow going forward.
- EXPECT_FALSE(navigation_manager()->CanGoForward());
- EXPECT_FALSE(navigation_manager()->CanGoToOffset(1));
-}
-
// Tests that going forward or positive offset is not possible without a
// committed item.
TEST_F(NavigationManagerTest, CanGoForwardWithoutCommitedItem) {
« no previous file with comments | « ios/web/navigation/navigation_manager_impl.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698