Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: ios/web/navigation/navigation_manager_impl.mm

Issue 2775893003: Removed dead code from NavigationManagerImpl::GetIndexForOffset. (Closed)
Patch Set: Actually removed dead code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/navigation/navigation_manager_impl.mm
diff --git a/ios/web/navigation/navigation_manager_impl.mm b/ios/web/navigation/navigation_manager_impl.mm
index a059c1d0e3c19f4421442ccc06de66ddcc44dd38..863ba8a95395b861af114cf48b2e3194c08669b7 100644
--- a/ios/web/navigation/navigation_manager_impl.mm
+++ b/ios/web/navigation/navigation_manager_impl.mm
@@ -393,16 +393,6 @@ int NavigationManagerImpl::GetIndexForOffset(int offset) const {
if (result > GetItemCount() /* overflow */)
result = INT_MIN;
} else if (offset > 0) {
- if (GetPendingItem() && [session_controller_ pendingItemIndex] == -1) {
- // Chrome for iOS does not allow forward navigation if there is another
- // pending navigation in progress. Returning invalid index indicates that
- // forward navigation will not be allowed (and |INT_MAX| works for that).
- // This is different from other platforms which allow forward navigation
- // if pending item exist.
- // TODO(crbug.com/661858): Remove this once back-forward navigation uses
- // pending index.
- return INT_MAX;
- }
while (offset > 0 && result < GetItemCount()) {
++result;
--offset;
« no previous file with comments | « ios/web/navigation/crw_session_controller.mm ('k') | ios/web/navigation/navigation_manager_impl_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698