Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2775863004: Add error checking for the immutable annotation (issue 27750) (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson
Modified:
3 years, 9 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add error checking for the immutable annotation (issue 27750) R=pquitslund@google.com Committed: https://github.com/dart-lang/sdk/commit/4f28d97ac23605a280b6ad26d78d83655018af0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -6 lines) Patch
M pkg/analyzer/lib/dart/element/element.dart View 3 chunks +11 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/error/error.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/error/hint_codes.dart View 2 chunks +17 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 4 chunks +92 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 4 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 9 months ago (2017-03-24 18:52:37 UTC) #2
pquitslund
lgtm
3 years, 9 months ago (2017-03-24 18:55:46 UTC) #3
Brian Wilkerson
3 years, 9 months ago (2017-03-24 18:56:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4f28d97ac23605a280b6ad26d78d83655018af0f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698