Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 2775763002: Block 'ftp:' subresource requests from non-'ftp:' pages. (Closed)
Patch Set: Rebaseline. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
index d267da610300fd28151cce77f7237c92549ea124..4aa9e4a6c39334b3c73f8a8c6c13bb1e7d9a59fc 100644
--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
@@ -784,8 +784,7 @@ ResourceRequestBlockedReason FrameFetchContext::canRequestInternal(
// Measure the number of legacy URL schemes ('ftp://') and the number of
// embedded-credential ('http://user:password@...') resources embedded as
- // subresources. in the hopes that we can block them at some point in the
- // future.
+ // subresources.
if (resourceRequest.frameType() != WebURLRequest::FrameTypeTopLevel) {
DCHECK(frame()->document());
if (SchemeRegistry::shouldTreatURLSchemeAsLegacy(url.protocol()) &&
@@ -794,8 +793,8 @@ ResourceRequestBlockedReason FrameFetchContext::canRequestInternal(
Deprecation::countDeprecation(
frame()->document(), UseCounter::LegacyProtocolEmbeddedAsSubresource);
- // TODO(mkwst): Drop the runtime-enabled check in M59:
- // https://www.chromestatus.com/feature/5709390967472128
+ // TODO(mkwst): Enabled by default in M59. Drop the runtime-enabled check
+ // in M60: https://www.chromestatus.com/feature/5709390967472128
if (RuntimeEnabledFeatures::blockLegacySubresourcesEnabled())
return ResourceRequestBlockedReason::Origin;
}
« no previous file with comments | « third_party/WebKit/Source/core/frame/Deprecation.cpp ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698