Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 277573003: Fix repaint rects from fast/repaint/window-resize tests (Closed)

Created:
6 years, 7 months ago by enne (OOO)
Modified:
6 years, 7 months ago
Reviewers:
ojan, abarth-chromium
CC:
blink-reviews, esprehn
Visibility:
Public.

Description

Fix repaint rects from fast/repaint/window-resize tests By observation, these tests are supposed to be printing out multiple sets of repaint rects. text-based-repaint doesn't handle multiple sets of runRepaintTest, so for this unfortunately synchronous resize API, just have it handle all the repaints itself. This is also the only synchronous-requiring repaint test, so fixing this makes it easier to make all repaint tests actually go through the full asynchronous paint path. BUG=361729 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173770

Patch Set 1 #

Patch Set 2 : TextExpectations #

Total comments: 2

Patch Set 3 : Rebase, fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/fast/repaint/resources/window-resize-repaint.js View 1 2 1 chunk +11 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/window-resize-fixed-center-background-image.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/window-resize-media-query.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/window-resize-no-layout-change1.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/window-resize-no-layout-change2.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/window-resize-percent-html.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/window-resize-percent-width-height.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/window-resize-positioned-bottom.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/window-resize-positioned-percent-top.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/window-resize-vertical-writing-mode.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/window-resize-viewport-percent.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
enne (OOO)
6 years, 7 months ago (2014-05-08 20:38:31 UTC) #1
abarth-chromium
I'm going to defer to Ojan here.
6 years, 7 months ago (2014-05-09 03:15:07 UTC) #2
ojan
lgtm https://codereview.chromium.org/277573003/diff/20001/LayoutTests/fast/repaint/resources/window-resize-repaint.js File LayoutTests/fast/repaint/resources/window-resize-repaint.js (right): https://codereview.chromium.org/277573003/diff/20001/LayoutTests/fast/repaint/resources/window-resize-repaint.js#newcode34 LayoutTests/fast/repaint/resources/window-resize-repaint.js:34: repaintRects += window.internals.layerTreeAsText(document, window.internals.LAYER_TREE_INCLUDES_REPAINT_RECTS); Nit: s/window.internals/internals/
6 years, 7 months ago (2014-05-09 03:19:30 UTC) #3
Xianzhu
On 2014/05/09 03:19:30, ojan wrote: > lgtm > > https://codereview.chromium.org/277573003/diff/20001/LayoutTests/fast/repaint/resources/window-resize-repaint.js > File LayoutTests/fast/repaint/resources/window-resize-repaint.js (right): > ...
6 years, 7 months ago (2014-05-09 17:28:09 UTC) #4
enne (OOO)
On 2014/05/09 17:28:09, Xianzhu wrote: > I have a similar change https://codereview.chromium.org/275433007/. It contains > ...
6 years, 7 months ago (2014-05-09 17:59:46 UTC) #5
enne (OOO)
https://codereview.chromium.org/277573003/diff/20001/LayoutTests/fast/repaint/resources/window-resize-repaint.js File LayoutTests/fast/repaint/resources/window-resize-repaint.js (right): https://codereview.chromium.org/277573003/diff/20001/LayoutTests/fast/repaint/resources/window-resize-repaint.js#newcode34 LayoutTests/fast/repaint/resources/window-resize-repaint.js:34: repaintRects += window.internals.layerTreeAsText(document, window.internals.LAYER_TREE_INCLUDES_REPAINT_RECTS); On 2014/05/09 03:19:31, ojan wrote: ...
6 years, 7 months ago (2014-05-09 18:01:38 UTC) #6
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-05-09 18:01:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/277573003/40001
6 years, 7 months ago (2014-05-09 18:02:56 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 19:20:49 UTC) #9
Message was sent while issue was closed. 
Change committed as 173770

Powered by Google App Engine
This is Rietveld 408576698