Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: headless/lib/browser/headless_browser_impl.h

Issue 2775693003: Fix missing HEADLESS_EXPORT defines (Closed)
Patch Set: Do not include changes in BUILD fiel Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/browser/headless_browser_impl.h
diff --git a/headless/lib/browser/headless_browser_impl.h b/headless/lib/browser/headless_browser_impl.h
index 864e49c1c17cc666a7ed5a9ee757e8ffb256c9b6..04675932d3a72534ce5752f9c9a0e636fa130d99 100644
--- a/headless/lib/browser/headless_browser_impl.h
+++ b/headless/lib/browser/headless_browser_impl.h
@@ -16,6 +16,7 @@
#include "content/public/browser/web_contents.h"
#include "headless/lib/browser/headless_devtools_manager_delegate.h"
#include "headless/lib/browser/headless_web_contents_impl.h"
+#include "headless/public/headless_export.h"
#if defined(USE_AURA)
#include "headless/lib/browser/headless_window_tree_host.h"
@@ -32,7 +33,7 @@ namespace headless {
class HeadlessBrowserContextImpl;
class HeadlessBrowserMainParts;
-class HeadlessBrowserImpl : public HeadlessBrowser {
+class HEADLESS_EXPORT HeadlessBrowserImpl : public HeadlessBrowser {
Sami 2017/03/24 10:28:40 Are you sure this one is needed? The impl class sh
dvallet 2017/03/27 02:44:01 Done
public:
HeadlessBrowserImpl(
const base::Callback<void(HeadlessBrowser*)>& on_start_callback,

Powered by Google App Engine
This is Rietveld 408576698