LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange

third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
index 79c58d5dec8115e276f266d62685a090e5609cfb..ac5f6cf6f5f5fe51c4bedc92584d7cf0dfed3410 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
@@ -4004,4 +4004,36 @@ VisiblePositionInFlatTree previousPositionOf(
       visiblePosition.deepEquivalent(), rule);
 }
 
+template <typename Strategy>
+void textQuads(Vector<FloatQuad>& quad,

[Xiaocheng, 2017/03/28 21:29:34]

nit: Please make this function |static| and rename it to |textQuadAlgorithm| to
align with other functions in the same file.

[yosin_UTC9, 2017/03/29 02:31:40]

Could you change this function at "Range.cpp" with "TODO: we'll move blach..."
in this CL?
Then move this to "VisibleUnits.cpp" to see difference between Range and
EphemeralRange version easier?

[tanvir, 2017/03/30 19:11:05]

Done.

[tanvir, 2017/03/30 19:11:05]

I did not understand this comment from Range.cpp context. Could you please let
me know on this ?

+               const EphemeralRangeTemplate<Strategy>& range) {
+  const PositionTemplate<Strategy> startPosition = range.startPosition();
+  const PositionTemplate<Strategy> endPosition = range.endPosition();
+  Node* startContainer = startPosition.computeContainerNode();
+  DCHECK(startContainer);
+  Node* endContainer = endPosition.computeContainerNode();
+  DCHECK(endContainer);
+
+  for (Node& node : range.nodes()) {
+    LayoutObject* layoutObject = node.layoutObject();
+    if (!layoutObject || !layoutObject->isText())
+      continue;
+    LayoutText* layoutText = toLayoutText(layoutObject);
+    unsigned startOffset =
+        node == startContainer ? startPosition.offsetInContainerNode() : 0;
+    unsigned endOffset = node == endContainer
+                             ? endPosition.offsetInContainerNode()
+                             : std::numeric_limits<unsigned>::max();
+    layoutText->absoluteQuadsForRange(quad, startOffset, endOffset);
+  }
+}
+
+void textQuad(Vector<FloatQuad>& quad, const EphemeralRange& range) {
+  textQuads(quad, range);
+}
+
+void textQuad(Vector<FloatQuad>& quad, const EphemeralRangeInFlatTree& range) {
+  textQuads(quad, range);
+}
+
 }  // namespace blink