third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2775663008: LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2775663008: LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange (Closed)

Patch Set: Split Patch:1(TextQuads at VisibleUnits) Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index 77a4e3d57718b037499ec70e144e0487df158d69..8fc57dd52e3cb3cc4461d33a77bf38579c6f6ed4 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -1012,7 +1012,7 @@ FloatRect LayoutObject::absoluteBoundingBoxRectForRange(const Range* range) {

range->ownerDocument().updateStyleAndLayout();

Vector<FloatQuad> quads;

- range->textQuads(quads);

+ textQuads(&quads, EphemeralRange(range));

FloatRect result;

for (size_t i = 0; i < quads.size(); ++i)