third_party/WebKit/Source/core/layout/LayoutObject.h - Issue 2775663008: LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2775663008: LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange (Closed)

Patch Set: Addressed Review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h

index 76fbc890aad22bb48e02f75c967751a2475e9bd9..22193f76af0270169693a4dacb2f99707fdd3229 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h

@@ -30,6 +30,7 @@

#include "core/CoreExport.h"

#include "core/dom/Document.h"

#include "core/dom/DocumentLifecycle.h"

+#include "core/editing/EphemeralRange.h"

#include "core/editing/PositionWithAffinity.h"

#include "core/layout/LayoutObjectChildList.h"

#include "core/layout/MapCoordinatesFlags.h"

@@ -1303,7 +1304,7 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,

virtual void absoluteQuads(Vector<FloatQuad>&,

MapCoordinatesFlags mode = 0) const {}

- static FloatRect absoluteBoundingBoxRectForRange(const Range*);

+ static FloatRect absoluteBoundingBoxRectForRange(const EphemeralRange&);

// The bounding box (see: absoluteBoundingBoxRect) including all descendant

// bounding boxes.