LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange

third_party/WebKit/Source/core/editing/VisibleUnits.h

Index: third_party/WebKit/Source/core/editing/VisibleUnits.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.h b/third_party/WebKit/Source/core/editing/VisibleUnits.h
index e089580682abb7880085806bcc1f079bbd4f418d..d2c74ba280a1e666ed77fcfb2bf0b007b2467d29 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.h
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.h
@@ -340,6 +340,9 @@ CORE_EXPORT bool rendersInDifferentPosition(const Position&, const Position&);
 CORE_EXPORT Position skipWhitespace(const Position&);
 CORE_EXPORT PositionInFlatTree skipWhitespace(const PositionInFlatTree&);
 
+CORE_EXPORT void textQuads(Vector<FloatQuad>&, const EphemeralRange&);

[Xiaocheng, 2017/03/31 18:01:19]

Please use |Vector<FloatQuad>*| to pass output parameter because Google coding
style doesn't allow passing non-const reference parameters:

https://google.github.io/styleguide/cppguide.html#Reference_Arguments

Some old code may violate it, but at least we shouldn't create new violations.

[tanvir, 2017/04/03 13:00:48]

Done.

+CORE_EXPORT void textQuads(Vector<FloatQuad>&, const EphemeralRangeInFlatTree&);
+
 }  // namespace blink
 
 #endif  // VisibleUnits_h