third_party/WebKit/Source/web/tests/TextFinderTest.cpp - Issue 2775663008: LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/TextFinderTest.cpp

Issue 2775663008: LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange (Closed)

Patch Set: Review comments Addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/TextFinderTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/TextFinderTest.cpp b/third_party/WebKit/Source/web/tests/TextFinderTest.cpp

index f1ad3306991f66455bccfd12d6f3abc9886e8c9d..6e8205e752c3c430bc7e90362a826dd156d8f153 100644

--- a/third_party/WebKit/Source/web/tests/TextFinderTest.cpp

+++ b/third_party/WebKit/Source/web/tests/TextFinderTest.cpp

@@ -64,8 +64,9 @@ WebFloatRect TextFinderTest::findInPageRect(Node* startContainer,

int startOffset,

Node* endContainer,

int endOffset) {

- Range* range = Range::create(startContainer->document(), startContainer,

- startOffset, endContainer, endOffset);

+ const Position startPosition(startContainer, startOffset);

+ const Position endPosition(endContainer, endOffset);

+ EphemeralRange range(startPosition, endPosition);

return WebFloatRect(findInPageRectFromRange(range));

}