LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange

third_party/WebKit/Source/web/FindInPageCoordinates.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 125 matching lines @@
     DCHECK(layoutObject->isLayoutView());
 
     // Jump to the layoutObject owning the frame, if any.
     layoutObject =
         layoutObject->frame() ? layoutObject->frame()->ownerLayoutObject() : 0;
   }
 
   return normalizedRect;
 }
 
-FloatRect findInPageRectFromRange(Range* range) {
-  if (!range || !range->firstNode())
+FloatRect findInPageRectFromRange(EphemeralRange& range) {
+  if (range.isNull())
+    return FloatRect();
+
+  const LayoutObject* baseLayoutObject =
+      range.startPosition().nodeAsRangeFirstNode()->layoutObject();

[Xiaocheng, 2017/03/28 21:29:34]

Should have null ptr check for range.startPosition().nodeAsRangeFirstNode().

[tanvir, 2017/03/30 19:11:06]

Done.

+  if (!baseLayoutObject)
     return FloatRect();
 
   return findInPageRectFromAbsoluteRect(
-      LayoutObject::absoluteBoundingBoxRectForRange(range),
-      range->firstNode()->layoutObject());
+      LayoutObject::absoluteBoundingBoxRectForRange(range), baseLayoutObject);
 }
 
 }  // namespace blink