third_party/WebKit/Source/core/editing/VisibleUnits.h - Issue 2775663008: LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/VisibleUnits.h

Issue 2775663008: LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange (Closed)

Patch Set: Split Patch:1(TextQuads at VisibleUnits) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.	2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 322 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
333 // Returns a hit-tested VisiblePosition for the given point in contents-space	333 // Returns a hit-tested VisiblePosition for the given point in contents-space

334 // coordinates.	334 // coordinates.

335 CORE_EXPORT VisiblePosition visiblePositionForContentsPoint(const IntPoint&,	335 CORE_EXPORT VisiblePosition visiblePositionForContentsPoint(const IntPoint&,

336 LocalFrame*);	336 LocalFrame*);

337	337

338 CORE_EXPORT bool rendersInDifferentPosition(const Position&, const Position&);	338 CORE_EXPORT bool rendersInDifferentPosition(const Position&, const Position&);

339	339

340 CORE_EXPORT Position skipWhitespace(const Position&);	340 CORE_EXPORT Position skipWhitespace(const Position&);

341 CORE_EXPORT PositionInFlatTree skipWhitespace(const PositionInFlatTree&);	341 CORE_EXPORT PositionInFlatTree skipWhitespace(const PositionInFlatTree&);

342	342

	343 CORE_EXPORT void textQuads(Vector<FloatQuad>*, const EphemeralRange&);
	yosin_UTC9 2017/04/04 01:25:22 Please name this function as \|computeTextQuads()\| Please name this function as \|computeTextQuads()\| to make function name starts with verb.
	344 CORE_EXPORT void textQuads(Vector<FloatQuad>*, const EphemeralRangeInFlatTree&);

	345

343 } // namespace blink	346 } // namespace blink

344	347

345 #endif // VisibleUnits_h	348 #endif // VisibleUnits_h

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('j') | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('J')