LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange

third_party/WebKit/Source/core/editing/EphemeralRange.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/EphemeralRange.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/Range.h"
 #include "core/dom/Text.h"
+#include "core/layout/LayoutObject.h"
+#include "core/layout/LayoutText.h"
 
 namespace blink {
 
 namespace {
 template <typename Strategy>
 Node* commonAncestorContainerNode(const Node* containerA,
                                   const Node* containerB) {
   if (!containerA || !containerB)
     return nullptr;
   return Strategy::commonAncestor(*containerA, *containerB);
@@ skipping 118 matching lines @@
 }
 
 template <typename Strategy>
 EphemeralRangeTemplate<Strategy>
 EphemeralRangeTemplate<Strategy>::rangeOfContents(const Node& node) {
   return EphemeralRangeTemplate<Strategy>(
       PositionTemplate<Strategy>::firstPositionInNode(&const_cast<Node&>(node)),
       PositionTemplate<Strategy>::lastPositionInNode(&const_cast<Node&>(node)));
 }
 
+template <typename Strategy>
+void EphemeralRangeTemplate<Strategy>::textQuads(

[Xiaocheng, 2017/03/24 18:19:26]

I'm shocked by that we currently don't have unit test for Range::textQuads..

Could you add unit tests for EphemeralRange::textQuads and
EphemeralRangeInFlatTree::textQuads, to help us make our code base healthier? :)

[yoichio, 2017/03/27 05:24:46]

We want EphemeralRange to be independent from Layout.
Could you define textQuads at VisibleUnit?

[tanvir, 2017/03/28 13:39:08]

Done.

[tanvir, 2017/03/28 13:39:08]

Done.

+    Vector<FloatQuad>& quads) const {
+  Node* startContainer = m_startPosition.computeContainerNode();
+  DCHECK(startContainer);
+  Node* endContainer = m_endPosition.computeContainerNode();
+  DCHECK(endContainer);
+
+  for (Node& node : nodes()) {
+    LayoutObject* r = node.layoutObject();

[yosin_UTC9, 2017/03/27 05:43:14]

Please avoid to use one letter variable name.
BTW, |r| comes from we called |LayoutObject| as |RenderedObject|. At this time
|r| is meaningless.

[tanvir, 2017/03/28 13:39:08]

Done. 

+    if (!r || !r->isText())
+      continue;
+    LayoutText* layoutText = toLayoutText(r);
+    unsigned startOffset =
+        node == startContainer ? m_startPosition.offsetInContainerNode() : 0;
+    unsigned endOffset = node == endContainer
+                             ? m_endPosition.offsetInContainerNode()
+                             : std::numeric_limits<unsigned>::max();
+    layoutText->absoluteQuadsForRange(quads, startOffset, endOffset);
+  }
+}
+
 #if DCHECK_IS_ON()
 template <typename Strategy>
 bool EphemeralRangeTemplate<Strategy>::isValid() const {
   return m_startPosition.isNull() ||
          m_domTreeVersion == m_startPosition.document()->domTreeVersion();
 }
 #else
 template <typename Strategy>
 bool EphemeralRangeTemplate<Strategy>::isValid() const {
   return true;
 }
 #endif
 
 Range* createRange(const EphemeralRange& range) {
   if (range.isNull())
     return nullptr;
   return Range::create(range.document(), range.startPosition(),
                        range.endPosition());
 }
 
 template class CORE_TEMPLATE_EXPORT EphemeralRangeTemplate<EditingStrategy>;
 template class CORE_TEMPLATE_EXPORT
     EphemeralRangeTemplate<EditingInFlatTreeStrategy>;
 
 }  // namespace blink