Use ansi color in the dartanalyzer cli output.

Use ansi color in the dartanalyzer cli output.

BUG=
R=brianwilkerson@google.com, danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/b51d1fd8e39964a24129de0ca088f49947c938df

[devoncarew, 2017-03-23 16:59:32]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, danrubel@google.com

[danrubel, 2017-03-23 17:04:05]

Nice! LGTM

[Brian Wilkerson, 2017-03-23 17:09:51]

Assuming the tests will work on Windows, lgtm.

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/lib/src/an...
File pkg/analyzer_cli/lib/src/ansi.dart (right):

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/lib/src/an...
pkg/analyzer_cli/lib/src/ansi.dart:16: class AnsiLogger {
Seems like this would be useful across multiple tools. There are two packages on
pub that provide some level of support:
- https://pub.dartlang.org/packages/ansicolor
- https://pub.dartlang.org/packages/console
Should we be using one of them?

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/lib/src/op...
File pkg/analyzer_cli/lib/src/options.dart (right):

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/lib/src/op...
pkg/analyzer_cli/lib/src/options.dart:392: ..addFlag('color',
Should this be shared with DDC?

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/test/drive...
File pkg/analyzer_cli/test/driver_test.dart (right):

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/test/drive...
pkg/analyzer_cli/test/driver_test.dart:183: contains('lint • Name types using
UpperCamelCase'));
Will this work on Windows? Perhaps we should expect the error severity and
message separately.

[karlklose, 2017-03-24 09:08:08]

karlklose@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2017-03-24 09:08:08]

DBC

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/lib/src/an...
File pkg/analyzer_cli/lib/src/ansi.dart (right):

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/lib/src/an...
pkg/analyzer_cli/lib/src/ansi.dart:12: !Platform.isWindows &&
Here is the detection code we use in fasta, which also works on (recent builds
of) Windows 10:
https://github.com/dart-lang/sdk/blob/master/pkg/front_end/lib/src/fasta/colo...

[devoncarew, 2017-03-25 22:02:43]

Description was changed from

==========
Use ansi color in the dartanalyzer cli output.

BUG=
==========

to

==========
Use ansi color in the dartanalyzer cli output.

BUG=
R=brianwilkerson@google.com, danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b51d1fd8e39964a24129de0ca088f49947c938df
==========

[devoncarew, 2017-03-25 22:02:44]

Committed patchset #2 (id:20001) manually as
b51d1fd8e39964a24129de0ca088f49947c938df (presubmit successful).

[devoncarew, 2017-03-25 22:33:17]

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/lib/src/an...
File pkg/analyzer_cli/lib/src/ansi.dart (right):

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/lib/src/an...
pkg/analyzer_cli/lib/src/ansi.dart:12: !Platform.isWindows &&
On 2017/03/24 09:08:08, karlklose wrote:
> Here is the detection code we use in fasta, which also works on (recent builds
> of) Windows 10:
>
https://github.com/dart-lang/sdk/blob/master/pkg/front_end/lib/src/fasta/colo...

Thanks! Looks comprehensive. I know package:test and flutter have their own
detection code as well. We should likely unify where possible.

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/lib/src/an...
pkg/analyzer_cli/lib/src/ansi.dart:16: class AnsiLogger {
On 2017/03/23 17:09:51, Brian Wilkerson wrote:
> Seems like this would be useful across multiple tools. There are two packages
on
> pub that provide some level of support:
> - https://pub.dartlang.org/packages/ansicolor
> - https://pub.dartlang.org/packages/console
> Should we be using one of them?

Perhaps? I do like how lightweight our impl is, and that it doesn't introduce
dependencies. Would prefer to keep this minimal impl for now.

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/lib/src/op...
File pkg/analyzer_cli/lib/src/options.dart (right):

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/lib/src/op...
pkg/analyzer_cli/lib/src/options.dart:392: ..addFlag('color',
On 2017/03/23 17:09:51, Brian Wilkerson wrote:
> Should this be shared with DDC?

I don't think their output uses color (or plans to), but we could refactor to
have a shared plan if we want to update their cli output.

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/test/drive...
File pkg/analyzer_cli/test/driver_test.dart (right):

https://codereview.chromium.org/2775633002/diff/1/pkg/analyzer_cli/test/drive...
pkg/analyzer_cli/test/driver_test.dart:183: contains('lint • Name types using
UpperCamelCase'));
On 2017/03/23 17:09:51, Brian Wilkerson wrote:
> Will this work on Windows? Perhaps we should expect the error severity and
> message separately.

There is some checking for 'ansi.runningTests' in order to normalize output a 
bit when testing, so should still pass on windows. I think it does make sense to
split the two checks however, so will do that.

[kevmoo, 2017-03-27 01:06:21]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2017-03-27 01:06:22]

DBC: update the min required Dart SDK version?

...since this is a new feature.

Right?

[devoncarew, 2017-03-27 01:23:35]

We haven't changed the APIs we're using, and analyzer_cli isn't a published
package...