Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2654)

Unified Diff: chrome/browser/services/gcm/gcm_service.h

Issue 277563008: [Signin] Remove a reference to an obsolete bug. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/gcm_service.h
diff --git a/chrome/browser/services/gcm/gcm_service.h b/chrome/browser/services/gcm/gcm_service.h
index 321be2ea31d133921c56a15f03322ff9f4b66663..a5670252cb7eaae21a94a700011042ef1e4c8066 100644
--- a/chrome/browser/services/gcm/gcm_service.h
+++ b/chrome/browser/services/gcm/gcm_service.h
@@ -72,13 +72,13 @@ class GCMService : public IdentityProvider::Observer {
// |callback|: to be called once the asynchronous operation is done.
virtual void Register(const std::string& app_id,
const std::vector<std::string>& sender_ids,
- RegisterCallback callback);
+ const RegisterCallback& callback);
// Unregisters an app from using GCM.
// |app_id|: application ID.
// |callback|: to be called once the asynchronous operation is done.
virtual void Unregister(const std::string& app_id,
- UnregisterCallback callback);
+ const UnregisterCallback& callback);
// Sends a message to a given receiver.
// |app_id|: application ID.
@@ -88,7 +88,7 @@ class GCMService : public IdentityProvider::Observer {
virtual void Send(const std::string& app_id,
const std::string& receiver_id,
const GCMClient::OutgoingMessage& message,
- SendCallback callback);
+ const SendCallback& callback);
// For testing purpose.
GCMClient* GetGCMClientForTesting() const;
@@ -102,10 +102,12 @@ class GCMService : public IdentityProvider::Observer {
// Get GCM client internal states and statistics.
// If clear_logs is true then activity logs will be cleared before the stats
// are returned.
- void GetGCMStatistics(GetGCMStatisticsCallback callback, bool clear_logs);
+ void GetGCMStatistics(const GetGCMStatisticsCallback& callback,
+ bool clear_logs);
// Enables/disables GCM activity recording, and then returns the stats.
- void SetGCMRecording(GetGCMStatisticsCallback callback, bool recording);
+ void SetGCMRecording(const GetGCMStatisticsCallback& callback,
+ bool recording);
// IdentityProvider::Observer:
virtual void OnActiveAccountLogin() OVERRIDE;
« no previous file with comments | « no previous file | chrome/browser/services/gcm/gcm_service.cc » ('j') | chrome/browser/services/gcm/gcm_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698