Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 277563006: Introduces another change id to hierarchy mutations (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Introduces another change id to hierarchy mutations The expectation is that clients sending changes to the server always increment the value. The server only accepts changes if the ids match, otherwise the change is rejected. This puts the onus on the client as to how to resolve out of order changes. BUG=365012 TEST=covered by tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269832

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -178 lines) Patch
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h View 1 2 2 chunks +18 lines, -15 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 2 15 chunks +57 lines, -45 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 2 3 chunks +47 lines, -22 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 1 2 5 chunks +24 lines, -5 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 1 2 4 chunks +30 lines, -24 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 1 2 2 chunks +10 lines, -5 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 1 2 8 chunks +54 lines, -28 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 2 19 chunks +156 lines, -34 lines 0 comments Download
M mojo/tools/data/unittests View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 7 months ago (2014-05-08 19:57:26 UTC) #1
Ben Goodger (Google)
lgtm if you get rid of the unneeded client change id also.
6 years, 7 months ago (2014-05-08 20:25:47 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-12 15:26:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/277563006/40001
6 years, 7 months ago (2014-05-12 15:26:44 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 18:58:02 UTC) #5
Message was sent while issue was closed.
Change committed as 269832

Powered by Google App Engine
This is Rietveld 408576698