Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 277563004: [SVG2] overflow should be ignored in img and background-image. (Closed)

Created:
6 years, 7 months ago by Erik Dahlström (inactive)
Modified:
6 years, 7 months ago
Reviewers:
fs
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[SVG2] overflow should be ignored in img and background-image. BUG=371250 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173752

Patch Set 1 #

Patch Set 2 : add reftest #

Patch Set 3 : yet another test #

Total comments: 1

Patch Set 4 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -0 lines) Patch
A LayoutTests/svg/as-background-image/overflow-auto.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-background-image/overflow-auto-expected.html View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-image/overflow-auto.html View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-image/overflow-auto-expected.html View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-image/resources/overflow-auto.svg View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-image/resources/overflow-hidden.svg View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Erik Dahlström (inactive)
6 years, 7 months ago (2014-05-08 12:32:07 UTC) #1
fs
On 2014/05/08 12:32:07, Erik Dahlström wrote: Testcase?
6 years, 7 months ago (2014-05-08 14:02:18 UTC) #2
Erik Dahlström (inactive)
On 2014/05/08 14:02:18, fs wrote: > On 2014/05/08 12:32:07, Erik Dahlström wrote: > > Testcase? ...
6 years, 7 months ago (2014-05-08 15:32:57 UTC) #3
fs
LGTM w/ nit. https://codereview.chromium.org/277563004/diff/40001/LayoutTests/svg/as-background-image/overflow-auto-expected.html File LayoutTests/svg/as-background-image/overflow-auto-expected.html (right): https://codereview.chromium.org/277563004/diff/40001/LayoutTests/svg/as-background-image/overflow-auto-expected.html#newcode7 LayoutTests/svg/as-background-image/overflow-auto-expected.html:7: background-image: url(data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4KPCEtLSBHZW5lcmF0b3I6IEFkb2JlIElsbHVzdHJhdG9yIDE3LjEuMCwgU1ZHIEV4cG9ydCBQbHVnLUluIC4gU1ZHIFZlcnNpb246IDYuMDAgQnVpbGQgMCkgIC0tPgo8IURPQ1RZUEUgc3ZnIFBVQkxJQyAiLS8vVzNDLy9EVEQgU1ZHIDEuMS8vRU4iICJodHRwOi8vd3d3LnczLm9yZy9HcmFwaGljcy9TVkcvMS4xL0RURC9zdmcxMS5kdGQiPgo8c3ZnIHZlcnNpb249IjEuMSIgaWQ9IkxheWVyXzEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiIHg9IjBweCIgeT0iMHB4IgoJIHdpZHRoPSI0MHB4IiBoZWlnaHQ9IjQwcHgiIHZpZXdCb3g9IjAgMCA0MCA0MCIgZW5hYmxlLWJhY2tncm91bmQ9Im5ldyAwIDAgNDAgNDAiIHhtbDpzcGFjZT0icHJlc2VydmUiIG92ZXJmbG93PSJoaWRkZW4iPgo8bGluZWFyR3JhZGllbnQgaWQ9IlNWR0lEXzFfIiBncmFkaWVudFVuaXRzPSJ1c2VyU3BhY2VPblVzZSIgeDE9IjUuODU3OSIgeTE9IjUuODU3OSIgeDI9IjM0LjE0MjEiIHkyPSIzNC4xNDIxIiBncmFkaWVudFRyYW5zZm9ybT0ibWF0cml4KDAuNzA3MSAwLjcwNzEgLTAuNzA3MSAwLjcwNzEgMjAgLTguMjg0MykiPgoJPHN0b3AgIG9mZnNldD0iMCIgc3R5bGU9InN0b3AtY29sb3I6IzAwQTk5NSIvPgoJPHN0b3AgIG9mZnNldD0iMCIgc3R5bGU9InN0b3AtY29sb3I6IzNDMzc5NSIvPgoJPHN0b3AgIG9mZnNldD0iMC41MDU2IiBzdHlsZT0ic3RvcC1jb2xvcjojQTUzNTk0Ii8+Cgk8c3RvcCAgb2Zmc2V0PSIxIiBzdHlsZT0ic3RvcC1jb2xvcjojREEyMTI4Ii8+CjwvbGluZWFyR3JhZGllbnQ+Cjxwb2x5Z29uIGZpbGw9InVybCgjU1ZHSURfMV8pIiBwb2ludHM9IjIwLDQwIDAsMjAgMjAsMCA0MCwyMCAiLz4KPC9zdmc+Cg==); Nit: It's non-obvious how ...
6 years, 7 months ago (2014-05-09 12:18:27 UTC) #4
Erik Dahlström (inactive)
The CQ bit was checked by ed@opera.com
6 years, 7 months ago (2014-05-09 12:41:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/277563004/60001
6 years, 7 months ago (2014-05-09 12:42:38 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 14:02:28 UTC) #7
Message was sent while issue was closed.
Change committed as 173752

Powered by Google App Engine
This is Rietveld 408576698