Update DomDistillerJsUpdater and Roll DomDistillerJs

Update DomDistillerJsUpdater and Roll DomDistillerJs

The update script should build `ant package` and copy the entire
out/package directory.

This moves the path to domdistiller.js to .../package/js so update
that reference.

The old (non-proto) API is still supported, so this keeps using that.

Picked up changes:
fdb023d Fix Proto module's path
44e9366 This adds two simple protoc plugins.

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269485

[cjhopman, 2014-05-07 21:38:37]

yfriedman: *

[cjhopman, 2014-05-07 21:41:23]

On 2014/05/07 21:38:37, cjhopman wrote:
> yfriedman: *

This is wrong. The update script needs to be updated.

[Yaron, 2014-05-07 21:49:59]

On 2014/05/07 21:41:23, cjhopman wrote:
> On 2014/05/07 21:38:37, cjhopman wrote:
> > yfriedman: *
> 
> This is wrong. The update script needs to be updated.

Doesn't this require a change to use proto API or old one still supported? If
latter lgtm

[cjhopman, 2014-05-07 22:03:04]

This is now better. It now pulls in more stuff from the dom_distiller_js
library.

[Yaron, 2014-05-08 02:44:41]

https://codereview.chromium.org/277563002/diff/60001/third_party/dom_distille...
File
third_party/dom_distiller_js/package/proto_gen/dom_distiller_js/dom_distiller_json_converter.h
(right):

https://codereview.chromium.org/277563002/diff/60001/third_party/dom_distille...
third_party/dom_distiller_js/package/proto_gen/dom_distiller_js/dom_distiller_json_converter.h:1:
#include "dom_distiller_js/dom_distiller.pb.h"
Can't this be done as part of the build and stored in out/?

[cjhopman, 2014-05-08 18:52:07]

https://codereview.chromium.org/277563002/diff/60001/third_party/dom_distille...
File
third_party/dom_distiller_js/package/proto_gen/dom_distiller_js/dom_distiller_json_converter.h
(right):

https://codereview.chromium.org/277563002/diff/60001/third_party/dom_distille...
third_party/dom_distiller_js/package/proto_gen/dom_distiller_js/dom_distiller_json_converter.h:1:
#include "dom_distiller_js/dom_distiller.pb.h"
On 2014/05/08 02:44:42, Yaron wrote:
> Can't this be done as part of the build and stored in out/?
You mean generating this file?

It could be, but then we would have to pull in the protoc plugin for generating
it and either edit protoc.gypi/protoc_wrapper.py to support plugins or write a
new .gypi/.py for it. It seemed much simpler to just build it in domdistillerjs
and pull it in here.

The corresponding normal protoc-generation is done as part of the Chrome build.

[Yaron, 2014-05-08 21:15:31]

On 2014/05/08 18:52:07, cjhopman wrote:
>
https://codereview.chromium.org/277563002/diff/60001/third_party/dom_distille...
> File
>
third_party/dom_distiller_js/package/proto_gen/dom_distiller_js/dom_distiller_json_converter.h
> (right):
> 
>
https://codereview.chromium.org/277563002/diff/60001/third_party/dom_distille...
>
third_party/dom_distiller_js/package/proto_gen/dom_distiller_js/dom_distiller_json_converter.h:1:
> #include "dom_distiller_js/dom_distiller.pb.h"
> On 2014/05/08 02:44:42, Yaron wrote:
> > Can't this be done as part of the build and stored in out/?
> You mean generating this file?
> 
> It could be, but then we would have to pull in the protoc plugin for
generating
> it and either edit protoc.gypi/protoc_wrapper.py to support plugins or write a
> new .gypi/.py for it. It seemed much simpler to just build it in
domdistillerjs
> and pull it in here.
> 
> The corresponding normal protoc-generation is done as part of the Chrome
build.

lgtm

[cjhopman, 2014-05-09 00:13:12]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-05-09 00:16:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cjhopman@chromium.org/277563002/60001

[commit-bot: I haz the power, 2014-05-09 06:01:06]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-09 06:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 06:15:27]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[cjhopman, 2014-05-09 18:03:52]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-05-09 18:05:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cjhopman@chromium.org/277563002/60001

[commit-bot: I haz the power, 2014-05-10 02:15:03]

Change committed as 269485

[Alpha Left Google, 2014-05-10 06:20:43]

A revert of this CL has been created in
https://codereview.chromium.org/278143003/ by hclam@chromium.org.

The reason for reverting is: check_licenses failure:
http://build.chromium.org/p/chromium/builders/Linux/builds/49667.