Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: ios/chrome/browser/ui/omnibox_perftest.mm

Issue 2775623002: [ios] WebStateList owns all WebState it manages. (Closed)
Patch Set: Fix gn check Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/omnibox_perftest.mm
diff --git a/ios/chrome/browser/ui/omnibox_perftest.mm b/ios/chrome/browser/ui/omnibox_perftest.mm
index a8547a67d29ab6fc218bec5118e4ba6fb74e502d..81b373969f53766855279f64460aeaf592ed60a1 100644
--- a/ios/chrome/browser/ui/omnibox_perftest.mm
+++ b/ios/chrome/browser/ui/omnibox_perftest.mm
@@ -75,11 +75,10 @@ class OmniboxPerfTest : public PerfTest {
// Create a WebStateList that will always return the test WebState as
// the active WebState.
- web_state_list_ = base::MakeUnique<WebStateList>(
- &web_state_list_delegate_, WebStateList::WebStateOwned);
+ web_state_list_ = base::MakeUnique<WebStateList>(&web_state_list_delegate_);
std::unique_ptr<web::TestWebState> web_state =
base::MakeUnique<web::TestWebState>();
- web_state_list_->InsertWebState(0, web_state.release());
+ web_state_list_->InsertWebState(0, std::move(web_state));
// Creates the Toolbar for testing and sizes it to the width of the screen.
toolbar_model_delegate_.reset(
@@ -205,7 +204,6 @@ class OmniboxPerfTest : public PerfTest {
std::unique_ptr<TestChromeBrowserState> chrome_browser_state_;
FakeWebStateListDelegate web_state_list_delegate_;
std::unique_ptr<WebStateList> web_state_list_;
- web::WebState* web_state_;
std::unique_ptr<ToolbarModelDelegateIOS> toolbar_model_delegate_;
std::unique_ptr<ToolbarModelIOS> toolbar_model_ios_;
base::scoped_nsobject<WebToolbarController> toolbar_;

Powered by Google App Engine
This is Rietveld 408576698