Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: ios/chrome/browser/tabs/tab.h

Issue 2775623002: [ios] WebStateList owns all WebState it manages. (Closed)
Patch Set: Fix gn check Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/legacy_tab_helper.mm ('k') | ios/chrome/browser/tabs/tab.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab.h
diff --git a/ios/chrome/browser/tabs/tab.h b/ios/chrome/browser/tabs/tab.h
index 7d8fd8adcff9312ea33a4e6502ce39ea33505b11..8d6b1ce2c1e91cf72efaf2c5ab4bd5ada5110ebb 100644
--- a/ios/chrome/browser/tabs/tab.h
+++ b/ios/chrome/browser/tabs/tab.h
@@ -59,7 +59,6 @@ namespace web {
class NavigationItem;
class NavigationManager;
class NavigationManagerImpl;
-struct Referrer;
class WebState;
}
@@ -119,12 +118,6 @@ extern NSString* const kProxyPassthroughHeaderValue;
// ID associated with this tab.
@property(nonatomic, readonly) NSString* tabId;
-// ID of the opener of this tab.
-@property(nonatomic, readonly) NSString* openerID;
-
-// NavigationIndex of the opener of this tab.
-@property(nonatomic, readonly) NSInteger openerNavigationIndex;
-
// |YES| if snapshot overlay should load from the grey image cache.
@property(nonatomic, assign) BOOL useGreyImageCache;
@@ -166,43 +159,11 @@ extern NSString* const kProxyPassthroughHeaderValue;
// |YES| if the tab has finished loading.
@property(nonatomic, readonly) BOOL loadFinished;
-// Creates a new tab with the given state. |opener| is nil unless another tab
-// is conceptually the parent of this tab. |openedByDOM| is YES if the page was
-// opened by DOM. |model| and |browserState| must not be nil.
-- (instancetype)initWithBrowserState:(ios::ChromeBrowserState*)browserState
- opener:(Tab*)opener
- openedByDOM:(BOOL)openedByDOM
- model:(TabModel*)parentModel;
-
-// Create a new tab with given web state and tab model. All must be non-nil.
-- (instancetype)initWithWebState:(std::unique_ptr<web::WebState>)webState
- model:(TabModel*)parentModel;
-
-// Create a new tab with given web state and tab model, optionally attaching
-// the tab helpers (controlled by |attachTabHelpers|). All must be non-nil.
-- (instancetype)initWithWebState:(std::unique_ptr<web::WebState>)webState
- model:(TabModel*)parentModel
- attachTabHelpers:(BOOL)attachTabHelpers
- NS_DESIGNATED_INITIALIZER;
+// Creates a new Tab with the given WebState.
+- (instancetype)initWithWebState:(web::WebState*)webState;
- (instancetype)init NS_UNAVAILABLE;
-// Creates a new Tab instance loading |url| with |transition|, configured
-// with no TabModel. |opener| may be nil, and behaves exactly as for
-// -initWithBrowserState:opener:openedByDOM:model. |configuration| is a block
-// that will be run before |url| starts loading, and is the correct place to set
-// properties and delegates on the tab. Calling code must take ownership of the
-// tab -- this is particularly important with Tab instances, because they will
-// fail a DCHECK if they are deallocated without -close being called.
-+ (Tab*)preloadingTabWithBrowserState:(ios::ChromeBrowserState*)browserState
- url:(const GURL&)url
- referrer:(const web::Referrer&)referrer
- transition:(ui::PageTransition)transition
- provider:(id<CRWNativeContentProvider>)provider
- opener:(Tab*)opener
- desktopUserAgent:(BOOL)desktopUserAgent
- configuration:(void (^)(Tab*))configuration;
-
// Sets the parent tab model for this tab. Can only be called if the tab does
// not already have a parent tab model set.
// TODO(crbug.com/228575): Create a delegate interface and remove this.
@@ -237,9 +198,6 @@ extern NSString* const kProxyPassthroughHeaderValue;
// after this method completes.
- (void)terminateNetworkActivity;
-// Starts the tab's shutdown sequence.
-- (void)close;
-
// Dismisses all modals owned by the tab.
- (void)dismissModals;
« no previous file with comments | « ios/chrome/browser/tabs/legacy_tab_helper.mm ('k') | ios/chrome/browser/tabs/tab.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698