ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper_unittest.mm - Issue 2775623002: [ios] WebStateList owns all WebState it manages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper_unittest.mm

Issue 2775623002: [ios] WebStateList owns all WebState it manages. (Closed)

Patch Set: Remove Tab -willClose method (Tab implements CRWWebControllerObserver protocol). Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/shared/chrome/browser/tabs/web_state_list.h ('K') | « ios/shared/chrome/browser/tabs/web_state_list.mm ('k') | ios/shared/chrome/browser/tabs/web_state_list_order_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper_unittest.mm

diff --git a/ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper_unittest.mm b/ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper_unittest.mm

index ac1a3cdbc4eb1965d6d437f21ee4bab4300a376a..8d47f01ba703a1b9075e7ce373e13511606f5229 100644

--- a/ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper_unittest.mm

+++ b/ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper_unittest.mm

@@ -41,8 +41,7 @@ const char* const kURLs[] = {kURL0, kURL1, kURL2};

class WebStateListFastEnumerationHelperTest : public PlatformTest {

public:

WebStateListFastEnumerationHelperTest()

- : web_state_list_(&web_state_list_delegate_,

- WebStateList::WebStateOwned) {}

+ : web_state_list_(&web_state_list_delegate_) {}

NSArray* ArrayFromWebStateList() {

id<WebStateProxyFactory> proxy =

@@ -69,7 +68,7 @@ class WebStateListFastEnumerationHelperTest : public PlatformTest {

test_web_state->SetCurrentURL(GURL(urls[index]));

web_state_list_.InsertWebState(web_state_list_.count(),

- test_web_state.release());

+ std::move(test_web_state));

}