Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

Issue 2775623002: [ios] WebStateList owns all WebState it manages. (Closed)
Patch Set: Remove Tab -willClose method (Tab implements CRWWebControllerObserver protocol). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
diff --git a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
index 945ed8931fdde03f828233b29d034056fcca5fb5..4fdf8c9e437584d9ba2be242e302cd807d19885c 100644
--- a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
+++ b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
@@ -49,7 +49,7 @@
web::WebState::CreateParams webStateCreateParams(browser->browser_state());
std::unique_ptr<web::WebState> webState =
web::WebState::Create(webStateCreateParams);
- self.webStateList.InsertWebState(0, webState.release());
+ self.webStateList.InsertWebState(0, std::move(webState));
}
self.webStateList.ActivateWebStateAt(0);
}
@@ -96,8 +96,7 @@
}
- (void)closeTabAtIndex:(int)index {
- std::unique_ptr<web::WebState> closedWebState(
- self.webStateList.DetachWebStateAt(index));
+ self.webStateList.DetachWebStateAt(index);
}
- (void)createAndShowNewTab {
@@ -106,7 +105,7 @@
std::unique_ptr<web::WebState> webState =
web::WebState::Create(webStateCreateParams);
self.webStateList.InsertWebState(self.webStateList.count(),
- webState.release());
+ std::move(webState));
[self showTabAtIndex:self.webStateList.count() - 1];
}

Powered by Google App Engine
This is Rietveld 408576698