[ios] WebStateList owns all WebState it manages.

ios/chrome/browser/tabs/tab_unittest.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <UIKit/UIKit.h>
 
 #include <memory>
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/ios/block_types.h"
+#import "base/ios/weak_nsobject.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "components/bookmarks/test/bookmark_test_helpers.h"
 #include "components/history/core/browser/history_service.h"
 #include "components/keyed_service/core/service_access_type.h"
 #include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
 #include "ios/chrome/browser/browser_state/test_chrome_browser_state_manager.h"
 #import "ios/chrome/browser/chrome_url_util.h"
 #include "ios/chrome/browser/history/history_service_factory.h"
+#import "ios/chrome/browser/tabs/legacy_tab_helper.h"
 #import "ios/chrome/browser/tabs/tab.h"
+#import "ios/chrome/browser/tabs/tab_helper_util.h"
 #import "ios/chrome/browser/tabs/tab_model.h"
 #import "ios/chrome/browser/tabs/tab_private.h"
 #import "ios/chrome/browser/ui/open_in_controller.h"
 #import "ios/chrome/browser/ui/open_in_controller_testing.h"
 #import "ios/chrome/browser/web/external_app_launcher.h"
 #include "ios/chrome/test/block_cleanup_test.h"
 #include "ios/chrome/test/ios_chrome_scoped_testing_chrome_browser_provider.h"
 #include "ios/chrome/test/ios_chrome_scoped_testing_chrome_browser_state_manager.h"
 #include "ios/chrome/test/ios_chrome_scoped_testing_local_state.h"
 #import "ios/public/provider/chrome/browser/native_app_launcher/fake_native_app_metadata.h"
@@ skipping 51 matching lines @@
   return [tabsForTesting_ indexOfObject:tab];
 }
 
 - (NSUInteger)count {
   return [tabsForTesting_ count];
 }
 
 - (void)closeTabAtIndex:(NSUInteger)index {
   [tabsForTesting_ removeObjectAtIndex:index];
 }
-
-- (void)didCloseTab:(Tab*)closedTab {
-}
 @end
 
 @interface ExternalAppLauncherMock : OCMockComplexTypeHelper
 @end
 
 @implementation ExternalAppLauncherMock
 typedef BOOL (^openURLBlockType)(const GURL&, BOOL);
 
 - (BOOL)openURL:(const GURL&)url linkClicked:(BOOL)linkClicked {
   return static_cast<openURLBlockType>([self blockForSelector:_cmd])(
@@ skipping 76 matching lines @@
     history_service_ = ios::HistoryServiceFactory::GetForBrowserState(
         chrome_browser_state_.get(), ServiceAccessType::EXPLICIT_ACCESS);
 
     ios::ChromeBrowserState* browser_state = chrome_browser_state_.get();
     if (UseOffTheRecordBrowserState())
       browser_state = browser_state->GetOffTheRecordChromeBrowserState();
 
     mock_web_controller_ =
         [OCMockObject niceMockForClass:[CRWWebController class]];
     web::WebState::CreateParams create_params(browser_state);
-    auto web_state_impl = base::MakeUnique<WebStateImpl>(create_params);
-    web_state_impl->SetWebController(mock_web_controller_);
-    web_state_impl->GetNavigationManagerImpl().InitializeSession();
-    web_state_impl_ = web_state_impl.get();
+    web_state_impl_ = base::MakeUnique<WebStateImpl>(create_params);
+    web_state_impl_->SetWebController(mock_web_controller_);
+    web_state_impl_->GetNavigationManagerImpl().InitializeSession();
+    web::WebStateImpl* web_state_impl = web_state_impl_.get();
     [[[static_cast<OCMockObject*>(mock_web_controller_) stub]
-        andReturnValue:OCMOCK_VALUE(web_state_impl_)] webStateImpl];
+        andReturnValue:OCMOCK_VALUE(web_state_impl)] webStateImpl];
     web_controller_view_.reset([[UIView alloc] init]);
     [[[static_cast<OCMockObject*>(mock_web_controller_) stub]
         andReturn:web_controller_view_.get()] view];
-    tab_.reset([[Tab alloc] initWithWebState:std::move(web_state_impl)
-                                       model:nil
-                            attachTabHelpers:NO]);
+    LegacyTabHelper::CreateForWebState(web_state_impl_.get());
+    tab_.reset(LegacyTabHelper::GetTabForWebState(web_state_impl_.get()));
     web::NavigationManager::WebLoadParams load_params(
         GURL("chrome://version/"));
     [[tab_ webController] loadWithParams:load_params];
 
     // There should be no entries in the history at this point.
     history::QueryResults results;
     QueryAllHistory(&results);
     EXPECT_EQ(0UL, results.size());
     mock_external_app_launcher_.reset([[ExternalAppLauncherMock alloc]
         initWithRepresentedObject:
             [OCMockObject mockForClass:[ExternalAppLauncher class]]]);
     [tab_ replaceExternalAppLauncher:mock_external_app_launcher_];
   }
 
   void TearDown() override {
-    [tab_ close];
-
+    // Ensure that the Tab is destroyed before the autorelease pool is cleared.
+    web_state_impl_.reset();
     BlockCleanupTest::TearDown();
   }
 
   void BrowseTo(const GURL& userUrl, const GURL& redirectUrl, NSString* title) {
-    DCHECK_EQ(tab_.get().webState, web_state_impl_);
+    DCHECK_EQ(tab_.get().webState, web_state_impl_.get());
 
     [tab_ webWillAddPendingURL:userUrl transition:ui::PAGE_TRANSITION_TYPED];
     web_state_impl_->OnProvisionalNavigationStarted(userUrl);
     [tab_ webWillAddPendingURL:redirectUrl
                     transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT];
 
     web::Referrer empty_referrer;
     [tab_ navigationManagerImpl]->AddPendingItem(
         redirectUrl, empty_referrer, ui::PAGE_TRANSITION_CLIENT_REDIRECT,
         web::NavigationInitiationType::RENDERER_INITIATED);
 
     web_state_impl_->OnProvisionalNavigationStarted(redirectUrl);
     [[tab_ navigationManagerImpl]->GetSessionController() commitPendingItem];
     [[tab_ webController] webStateImpl]->UpdateHttpResponseHeaders(redirectUrl);
     [[tab_ webController] webStateImpl]->OnNavigationCommitted(redirectUrl);
 
     base::string16 new_title = base::SysNSStringToUTF16(title);
     [tab_ navigationManager]->GetLastCommittedItem()->SetTitle(new_title);
 
     web_state_impl_->OnTitleChanged();
     [[[(id)mock_web_controller_ expect]
         andReturnValue:OCMOCK_VALUE(kPageLoaded)] loadPhase];
     web_state_impl_->OnPageLoaded(redirectUrl, true);
   }
 
   void BrowseToNewTab() {
-    DCHECK_EQ(tab_.get().webState, web_state_impl_);
+    DCHECK_EQ(tab_.get().webState, web_state_impl_.get());
     const GURL url(kNewTabUrl);
     // TODO(crbug.com/661992): This will not work with a mock CRWWebController.
     // The only test that uses it is currently disabled.
     web::NavigationManager::WebLoadParams params(url);
     params.transition_type = ui::PAGE_TRANSITION_TYPED;
     [[tab_ webController] loadWithParams:params];
     [[[(id)mock_web_controller_ expect]
         andReturnValue:OCMOCK_VALUE(kPageLoading)] loadPhase];
     [[[(id)mock_web_controller_ expect]
         andReturnValue:OCMOCK_VALUE(kPageLoaded)] loadPhase];
@@ skipping 44 matching lines @@
     }
   }
 #endif
 
   virtual bool UseOffTheRecordBrowserState() const { return false; }
 
  protected:
   web::TestWebThreadBundle thread_bundle_;
   IOSChromeScopedTestingChromeBrowserStateManager scoped_browser_state_manager_;
   std::unique_ptr<TestChromeBrowserState> chrome_browser_state_;
-  base::scoped_nsobject<Tab> tab_;
-  web::WebStateImpl* web_state_impl_;
+  std::unique_ptr<web::WebStateImpl> web_state_impl_;
   history::HistoryService* history_service_;  // weak
   CRWWebController* mock_web_controller_;     // weak
   base::scoped_nsobject<UIView> web_controller_view_;
   base::scoped_nsobject<ArrayTabModel> tabModel_;
   base::scoped_nsobject<id> mock_external_app_launcher_;
+  base::WeakNSObject<Tab> tab_;
 };
 
 TEST_F(TabTest, AddToHistoryWithRedirect) {
   BrowseTo(GURL(kGoogleUserUrl), GURL(kGoogleRedirectUrl), kGoogleTitle);
   history::QueryResults results;
   QueryAllHistory(&results);
   EXPECT_EQ(1U, results.size());
   CheckHistoryResult(results[0], GURL(kGoogleRedirectUrl), kGoogleTitle);
   CheckCurrentItem(results[0]);
 }
@@ skipping 212 matching lines @@
       [[FakeNativeAppMetadata alloc] init]);
 
   // Turn auto open on.
   [metadata setShouldAutoOpenLinks:YES];
   int expectedCallCount = 2;
   TestOpenNativeAppURL(testURL, NO, expectedCallCount, NO);
   EXPECT_FALSE([metadata shouldAutoOpenLinks]);
 }
 
 }  // namespace