Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: ios/chrome/browser/ui/content_suggestions/content_suggestion.h

Issue 2775593002: Add a message to empty ContentSuggestions sections (Closed)
Patch Set: Reviewable Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTION_H_ 5 #ifndef IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTION_H_
6 #define IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTION_H_ 6 #define IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTION_H_
7 7
8 #import <UIKit/UIKit.h> 8 #import <UIKit/UIKit.h>
9 9
10 #import "ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion _identifier.h" 10 #import "ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion _identifier.h"
11 11
12 namespace base { 12 namespace base {
13 class Time; 13 class Time;
14 } 14 }
15 15
16 class GURL; 16 class GURL;
17 17
18 // Enum defining the type of a ContentSuggestions. 18 // Enum defining the type of a ContentSuggestions.
19 typedef NS_ENUM(NSInteger, ContentSuggestionType) { 19 typedef NS_ENUM(NSInteger, ContentSuggestionType) {
20 // Use this type pass information about an empty section. Suggestion of this
lpromero 2017/03/23 10:54:37 "to" pass?
gambard 2017/03/23 15:25:49 Done.
21 // type are empty and should not be displayed.
lpromero 2017/03/23 10:54:37 Why "should not be displayed"? Isn't there a messa
gambard 2017/03/23 15:25:49 Comment updated.
22 ContentSuggestionTypeEmpty,
20 ContentSuggestionTypeArticle 23 ContentSuggestionTypeArticle
21 }; 24 };
22 25
23 // Data for a suggestions item, compatible with Objective-C. Mostly acts as a 26 // Data for a suggestions item, compatible with Objective-C. Mostly acts as a
24 // wrapper for ntp_snippets::ContentSuggestion. 27 // wrapper for ntp_snippets::ContentSuggestion.
25 @interface ContentSuggestion : NSObject<ContentSuggestionIdentification> 28 @interface ContentSuggestion : NSObject<ContentSuggestionIdentification>
26 29
27 // Title of the suggestion. 30 // Title of the suggestion.
28 @property(nonatomic, copy, nullable) NSString* title; 31 @property(nonatomic, copy, nullable) NSString* title;
29 // Text for the suggestion. 32 // Text for the suggestion.
30 @property(nonatomic, copy, nullable) NSString* text; 33 @property(nonatomic, copy, nullable) NSString* text;
31 // Image for the suggestion. 34 // Image for the suggestion.
32 @property(nonatomic, strong, nullable) UIImage* image; 35 @property(nonatomic, strong, nullable) UIImage* image;
33 // URL associated with the suggestion. 36 // URL associated with the suggestion.
34 @property(nonatomic, assign) GURL url; 37 @property(nonatomic, assign) GURL url;
35 // The name of the publisher. 38 // The name of the publisher.
36 @property(nonatomic, copy, nullable) NSString* publisher; 39 @property(nonatomic, copy, nullable) NSString* publisher;
37 // The date of publication. 40 // The date of publication.
38 @property(nonatomic, assign) base::Time publishDate; 41 @property(nonatomic, assign) base::Time publishDate;
39 42
40 @property(nonatomic, assign) ContentSuggestionType type; 43 @property(nonatomic, assign) ContentSuggestionType type;
41 44
42 @end 45 @end
43 46
44 #endif // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTION_H_ 47 #endif // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698