Issue 2775563002: getComputedStyle should not always force a layout inside shadow trees.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2775563002: getComputedStyle should not always force a layout inside shadow trees. (Closed)

Created:
3 years, 9 months ago by esprehn

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

getComputedStyle should not always force a layout inside shadow trees. BUG=704421

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -5 lines)			Patch
	M	third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	third_party/WebKit/Source/core/dom/Document.cpp	View		1 chunk	+39 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

esprehn

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 06:36:55 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775563002/1

3 years, 9 months ago (2017-03-23 06:37:05 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 9 months ago (2017-03-23 06:52:07 UTC) #3

commit-bot: I haz the power

3 years, 9 months ago (2017-03-23 06:52:08 UTC) #4

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages