Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 277553002: Adds url to gclient json (try 2) (Closed)

Created:
6 years, 7 months ago by hinoka
Modified:
6 years, 7 months ago
Reviewers:
Ryan Tseng, agable, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, szager
Visibility:
Public.

Description

Adds url to gclient json (try 2) Reland of https://codereview.chromium.org/268373003/ with a fix (wraps the url with str()) https://codereview.chromium.org/268393002/ (bot_update root@revision support) is dependent on this BUG=370503 TEST= gclient sync --output-json ~/tmp/asdfasdf.json on both an SVN and Git checkout Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gclient.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Tseng
Also tested on a SVN solution this time.
6 years, 7 months ago (2014-05-07 21:25:36 UTC) #1
iannucci
this deserves some waterfall-watching, but lgtm
6 years, 7 months ago (2014-05-10 01:08:31 UTC) #2
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 7 months ago (2014-05-10 01:08:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/277553002/1
6 years, 7 months ago (2014-05-10 01:09:50 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 01:11:30 UTC) #5
Message was sent while issue was closed.
Change committed as 269469

Powered by Google App Engine
This is Rietveld 408576698