Chromium Code Reviews
|
|
DescriptionWebVR: match GVR renderbuffer resolution to canvas resolution
This is a partial revert of the VrShellGl refactor r438256 aka
http://crrev.com/2562733002 which had commented out this resolution
change.
Matching resolution improves visual quality and performance, the
internal rendering was at 3606x2268 instead of the intended 2560x1440
on a Pixel XL.
(This is a manual bugfix, basically a partial revert of 0be372f1b41a7e7ad897743abd6b265da979a82e or equivalently a partial cherry pick of 362c621af1b1c9ad8da5bac607a082108b4aa213, as approved by amineer@. Please see bug for details.)
BUG=704364
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2775513002
Cr-Commit-Position: refs/branch-heads/3029@{#402}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/59cacfe504a022686f7238bff37121f693ad4cc3
Patch Set 1 #Patch Set 2 : Fix stale TODO comment #Patch Set 3 : Rebase, fix Target Ref #
Messages
Total messages: 26 (13 generated)
klausw@chromium.org changed reviewers: + mthiesse@chromium.org
Adding a patchset didn't work, it created a new CL instead. Here's a version with fixed comment, I'll see if I can move that here: https://codereview.chromium.org/2770883003
On 2017/03/23 02:00:59, klausw wrote: > Adding a patchset didn't work, it created a new CL instead. Here's a version > with fixed comment, I'll see if I can move that here: > > https://codereview.chromium.org/2770883003 Nevermind, I got it sorted out. Needed to use "git cl upload --target_branch=branch_heads/3029" and manually set the rietveld issue in .git/config to fix the previous incomplete upload.
lgtm Code looks good, but please test this *very* thoroughly with both VR Shell and a bunch of different WebVR pages.
The CQ bit was checked by klausw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== WebVR: match GVR renderbuffer resolution to canvas resolution This is a partial revert of the VrShellGl refactor r438256 aka http://crrev.com/2562733002 which had commented out this resolution change. Matching resolution improves visual quality and performance, the internal rendering was at 3606x2268 instead of the intended 2560x1440 on a Pixel XL. BUG=704364 ========== to ========== WebVR: match GVR renderbuffer resolution to canvas resolution This is a partial revert of the VrShellGl refactor r438256 aka http://crrev.com/2562733002 which had commented out this resolution change. Matching resolution improves visual quality and performance, the internal rendering was at 3606x2268 instead of the intended 2560x1440 on a Pixel XL. (Partial revert of 0be372f1b41a7e7ad897743abd6b265da979a82e / partial cherry pick of 362c621af1b1c9ad8da5bac607a082108b4aa213 as manual bugfix, approved by amineer@) BUG=704364 NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by klausw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry for the inconvenience.
The CQ bit was checked by klausw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry for the inconvenience.
Description was changed from ========== WebVR: match GVR renderbuffer resolution to canvas resolution This is a partial revert of the VrShellGl refactor r438256 aka http://crrev.com/2562733002 which had commented out this resolution change. Matching resolution improves visual quality and performance, the internal rendering was at 3606x2268 instead of the intended 2560x1440 on a Pixel XL. (Partial revert of 0be372f1b41a7e7ad897743abd6b265da979a82e / partial cherry pick of 362c621af1b1c9ad8da5bac607a082108b4aa213 as manual bugfix, approved by amineer@) BUG=704364 NOTRY=true NOPRESUBMIT=true ========== to ========== WebVR: match GVR renderbuffer resolution to canvas resolution This is a partial revert of the VrShellGl refactor r438256 aka http://crrev.com/2562733002 which had commented out this resolution change. Matching resolution improves visual quality and performance, the internal rendering was at 3606x2268 instead of the intended 2560x1440 on a Pixel XL. (This is a manual bugfix, basically a partial revert of 0be372f1b41a7e7ad897743abd6b265da979a82e or equivalently a partial cherry pick of 362c621af1b1c9ad8da5bac607a082108b4aa213, as approved by amineer@. Please see bug for details.) BUG=704364 NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by klausw@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mthiesse@chromium.org Link to the patchset: https://codereview.chromium.org/2775513002/#ps40001 (title: "Rebase, fix Target Ref")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490331570324730,
"parent_rev": "6979eb487c47659e5f87900392237a7df5bf7b8a", "commit_rev":
"59cacfe504a022686f7238bff37121f693ad4cc3"}
Message was sent while issue was closed.
Description was changed from ========== WebVR: match GVR renderbuffer resolution to canvas resolution This is a partial revert of the VrShellGl refactor r438256 aka http://crrev.com/2562733002 which had commented out this resolution change. Matching resolution improves visual quality and performance, the internal rendering was at 3606x2268 instead of the intended 2560x1440 on a Pixel XL. (This is a manual bugfix, basically a partial revert of 0be372f1b41a7e7ad897743abd6b265da979a82e or equivalently a partial cherry pick of 362c621af1b1c9ad8da5bac607a082108b4aa213, as approved by amineer@. Please see bug for details.) BUG=704364 NOTRY=true NOPRESUBMIT=true ========== to ========== WebVR: match GVR renderbuffer resolution to canvas resolution This is a partial revert of the VrShellGl refactor r438256 aka http://crrev.com/2562733002 which had commented out this resolution change. Matching resolution improves visual quality and performance, the internal rendering was at 3606x2268 instead of the intended 2560x1440 on a Pixel XL. (This is a manual bugfix, basically a partial revert of 0be372f1b41a7e7ad897743abd6b265da979a82e or equivalently a partial cherry pick of 362c621af1b1c9ad8da5bac607a082108b4aa213, as approved by amineer@. Please see bug for details.) BUG=704364 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2775513002 Cr-Commit-Position: refs/branch-heads/3029@{#402} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/59cacfe504a022686f7238bff371... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/59cacfe504a022686f7238bff371...
Message was sent while issue was closed.
On 2017/03/24 05:03:39, commit-bot: I haz the power wrote: > Committed patchset #3 (id:40001) as > https://chromium.googlesource.com/chromium/src/+/59cacfe504a022686f7238bff371... FYI, the "internal error" from CQ was due to me using the wrong Target Ref, I had --target_branch=branch_heads/3029 instead of --target_branch=refs/branch-heads/3029 for my "git cl upload". Trooper ddoman@ forwarded me the assertion failure (thank you!), and I filed http://crbug.com/704819 due to the somewhat unhelpful error reporting. Re-doing "git cl upload" with the right --target_branch fixed it. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
