Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2775463002: Make --trace-loading great again. (Closed)

Created:
3 years, 9 months ago by rmacnak
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org, mfairhurst, maxkim
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/loader.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice_impl.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
rmacnak
We ran into an issue where we're weren't sure how a package was being resolved.
3 years, 9 months ago (2017-03-22 23:31:02 UTC) #2
mfairhurst
+Max Kim Thanks Ryan for handling this crazy quick!
3 years, 9 months ago (2017-03-22 23:37:08 UTC) #3
Florian Schneider
Lgtm
3 years, 9 months ago (2017-03-22 23:42:49 UTC) #5
rmacnak
3 years, 9 months ago (2017-03-23 00:06:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2aecd5e5880fc9d5ebf0a26edbb9c0b63c35fc6f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698