Issue 277543002: Some small cleanups for image filter code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 277543002: Some small cleanups for image filter code. (Closed)

Created:
6 years, 7 months ago by Stephen White

Modified:
6 years, 7 months ago

Reviewers:
Justin Novosad

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Some small cleanups for image filter code. Use the 2-param flavour of mapVector instead of the 3-param, where possible. Add an SkMatrixImageFilter test case to the tiling unit test. R=junov@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=14630

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -14 lines)			Patch
M	src/effects/SkBlurImageFilter.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/effects/SkDropShadowImageFilter.cpp	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	tests/ImageFilterTest.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Justin Novosad

On 2014/05/07 20:48:58, Stephen White wrote: > junov@: PTAL. Thanks! Missing test for DropShadowImageFilter

6 years, 7 months ago (2014-05-07 20:51:28 UTC) #2

Justin Novosad

On 2014/05/07 20:51:28, junov wrote: > On 2014/05/07 20:48:58, Stephen White wrote: > > junov@: ...

6 years, 7 months ago (2014-05-07 20:54:28 UTC) #3

Stephen White

6 years, 7 months ago (2014-05-07 20:56:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r14630 (presubmit successful).