Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java

Issue 2775403002: [Payments] Preview available payment options when no option is selected (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java
index cda39b2a3dba5c46a6c96bfc0d23c04f888fbeaf..e82daffea4e18a390df73915056e5dbc77dc314a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java
@@ -178,6 +178,31 @@ public class SectionInformation {
return 0;
}
+ /**
+ * Returns the resource Id for generating string to preview options in this section.
+ *
+ * @return The resource Id.
gone 2017/03/28 00:20:39 use "ID"; we only use "Id" in the Java function na
gogerald1 2017/03/28 18:46:24 Done.
+ */
+ public int getPreviewStringResourceId() {
+ int resId = 0;
please use gerrit instead 2017/03/27 20:28:31 No need for a temp variable. It's simpler to retur
gogerald1 2017/03/27 23:26:47 Done.
+ switch (mDataType) {
+ case PaymentRequestUI.TYPE_SHIPPING_ADDRESSES:
+ resId = R.string.payment_request_shipping_addresses_preview;
+ break;
+ case PaymentRequestUI.TYPE_SHIPPING_OPTIONS:
+ resId = R.string.payment_request_shipping_options_preview;
+ break;
+ case PaymentRequestUI.TYPE_PAYMENT_METHODS:
+ resId = R.string.payment_request_payment_methods_preview;
+ break;
+ case PaymentRequestUI.TYPE_CONTACT_DETAILS:
+ resId = R.string.payment_request_contacts_preview;
+ break;
+ }
please use gerrit instead 2017/03/27 20:28:31 default: assert false; return 0;
gogerald1 2017/03/27 23:26:47 Done.
+
+ return resId;
+ }
+
/** @param msg The optional error message to display when the selection is invalid. */
public void setErrorMessage(String msg) {
mErrorMessage = msg;

Powered by Google App Engine
This is Rietveld 408576698