Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: content/browser/fileapi/local_file_stream_writer_unittest.cc

Issue 2775383003: Move some fileapi tests next to the files they cover. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/fileapi/local_file_stream_writer_unittest.cc
diff --git a/content/browser/fileapi/local_file_stream_writer_unittest.cc b/content/browser/fileapi/local_file_stream_writer_unittest.cc
deleted file mode 100644
index ca798469091c538bc42dcf8f99384f24fbfcc318..0000000000000000000000000000000000000000
--- a/content/browser/fileapi/local_file_stream_writer_unittest.cc
+++ /dev/null
@@ -1,182 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "storage/browser/fileapi/local_file_stream_writer.h"
-
-#include <stdint.h>
-
-#include <memory>
-#include <string>
-
-#include "base/callback.h"
-#include "base/files/file_util.h"
-#include "base/files/scoped_temp_dir.h"
-#include "base/logging.h"
-#include "base/run_loop.h"
-#include "base/single_thread_task_runner.h"
-#include "base/threading/thread.h"
-#include "net/base/io_buffer.h"
-#include "net/base/test_completion_callback.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using storage::FileStreamWriter;
-using storage::LocalFileStreamWriter;
-
-namespace content {
-
-class LocalFileStreamWriterTest : public testing::Test {
- public:
- LocalFileStreamWriterTest()
- : file_thread_("FileUtilProxyTestFileThread") {}
-
- void SetUp() override {
- ASSERT_TRUE(file_thread_.Start());
- ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
- }
-
- void TearDown() override {
- // Give another chance for deleted streams to perform Close.
- base::RunLoop().RunUntilIdle();
- file_thread_.Stop();
- base::RunLoop().RunUntilIdle();
- }
-
- protected:
- base::FilePath Path(const std::string& name) {
- return temp_dir_.GetPath().AppendASCII(name);
- }
-
- int WriteStringToWriter(LocalFileStreamWriter* writer,
- const std::string& data) {
- scoped_refptr<net::StringIOBuffer> buffer(new net::StringIOBuffer(data));
- scoped_refptr<net::DrainableIOBuffer> drainable(
- new net::DrainableIOBuffer(buffer.get(), buffer->size()));
-
- while (drainable->BytesRemaining() > 0) {
- net::TestCompletionCallback callback;
- int result = writer->Write(
- drainable.get(), drainable->BytesRemaining(), callback.callback());
- if (result == net::ERR_IO_PENDING)
- result = callback.WaitForResult();
- if (result <= 0)
- return result;
- drainable->DidConsume(result);
- }
- return net::OK;
- }
-
- std::string GetFileContent(const base::FilePath& path) {
- std::string content;
- base::ReadFileToString(path, &content);
- return content;
- }
-
- base::FilePath CreateFileWithContent(const std::string& name,
- const std::string& data) {
- base::FilePath path = Path(name);
- base::WriteFile(path, data.c_str(), data.size());
- return path;
- }
-
- base::SingleThreadTaskRunner* file_task_runner() const {
- return file_thread_.task_runner().get();
- }
-
- LocalFileStreamWriter* CreateWriter(const base::FilePath& path,
- int64_t offset) {
- return new LocalFileStreamWriter(file_task_runner(), path, offset,
- FileStreamWriter::OPEN_EXISTING_FILE);
- }
-
- private:
- base::MessageLoopForIO message_loop_;
- base::Thread file_thread_;
- base::ScopedTempDir temp_dir_;
-};
-
-void NeverCalled(int unused) {
- ADD_FAILURE();
-}
-
-TEST_F(LocalFileStreamWriterTest, Write) {
- base::FilePath path = CreateFileWithContent("file_a", std::string());
- std::unique_ptr<LocalFileStreamWriter> writer(CreateWriter(path, 0));
- EXPECT_EQ(net::OK, WriteStringToWriter(writer.get(), "foo"));
- EXPECT_EQ(net::OK, WriteStringToWriter(writer.get(), "bar"));
- writer.reset();
- base::RunLoop().RunUntilIdle();
- EXPECT_TRUE(base::PathExists(path));
- EXPECT_EQ("foobar", GetFileContent(path));
-}
-
-TEST_F(LocalFileStreamWriterTest, WriteMiddle) {
- base::FilePath path = CreateFileWithContent("file_a", "foobar");
- std::unique_ptr<LocalFileStreamWriter> writer(CreateWriter(path, 2));
- EXPECT_EQ(net::OK, WriteStringToWriter(writer.get(), "xxx"));
- writer.reset();
- base::RunLoop().RunUntilIdle();
- EXPECT_TRUE(base::PathExists(path));
- EXPECT_EQ("foxxxr", GetFileContent(path));
-}
-
-TEST_F(LocalFileStreamWriterTest, WriteEnd) {
- base::FilePath path = CreateFileWithContent("file_a", "foobar");
- std::unique_ptr<LocalFileStreamWriter> writer(CreateWriter(path, 6));
- EXPECT_EQ(net::OK, WriteStringToWriter(writer.get(), "xxx"));
- writer.reset();
- base::RunLoop().RunUntilIdle();
- EXPECT_TRUE(base::PathExists(path));
- EXPECT_EQ("foobarxxx", GetFileContent(path));
-}
-
-TEST_F(LocalFileStreamWriterTest, WriteFailForNonexistingFile) {
- base::FilePath path = Path("file_a");
- ASSERT_FALSE(base::PathExists(path));
- std::unique_ptr<LocalFileStreamWriter> writer(CreateWriter(path, 0));
- EXPECT_EQ(net::ERR_FILE_NOT_FOUND, WriteStringToWriter(writer.get(), "foo"));
- writer.reset();
- base::RunLoop().RunUntilIdle();
- EXPECT_FALSE(base::PathExists(path));
-}
-
-TEST_F(LocalFileStreamWriterTest, CancelBeforeOperation) {
- base::FilePath path = Path("file_a");
- std::unique_ptr<LocalFileStreamWriter> writer(CreateWriter(path, 0));
- // Cancel immediately fails when there's no in-flight operation.
- int cancel_result = writer->Cancel(base::Bind(&NeverCalled));
- EXPECT_EQ(net::ERR_UNEXPECTED, cancel_result);
-}
-
-TEST_F(LocalFileStreamWriterTest, CancelAfterFinishedOperation) {
- base::FilePath path = CreateFileWithContent("file_a", std::string());
- std::unique_ptr<LocalFileStreamWriter> writer(CreateWriter(path, 0));
- EXPECT_EQ(net::OK, WriteStringToWriter(writer.get(), "foo"));
-
- // Cancel immediately fails when there's no in-flight operation.
- int cancel_result = writer->Cancel(base::Bind(&NeverCalled));
- EXPECT_EQ(net::ERR_UNEXPECTED, cancel_result);
-
- writer.reset();
- base::RunLoop().RunUntilIdle();
- // Write operation is already completed.
- EXPECT_TRUE(base::PathExists(path));
- EXPECT_EQ("foo", GetFileContent(path));
-}
-
-TEST_F(LocalFileStreamWriterTest, CancelWrite) {
- base::FilePath path = CreateFileWithContent("file_a", "foobar");
- std::unique_ptr<LocalFileStreamWriter> writer(CreateWriter(path, 0));
-
- scoped_refptr<net::StringIOBuffer> buffer(new net::StringIOBuffer("xxx"));
- int result =
- writer->Write(buffer.get(), buffer->size(), base::Bind(&NeverCalled));
- ASSERT_EQ(net::ERR_IO_PENDING, result);
-
- net::TestCompletionCallback callback;
- writer->Cancel(callback.callback());
- int cancel_result = callback.WaitForResult();
- EXPECT_EQ(net::OK, cancel_result);
-}
-
-} // namespace content
« no previous file with comments | « content/browser/fileapi/local_file_stream_reader_unittest.cc ('k') | content/browser/fileapi/native_file_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698