Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

Issue 2775373002: Add a Share Icon to Tabular Context Menu (Closed)
Patch Set: Fixes based off twellington's comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
index 177aed09146de67a39e34fbe3edb231245135220..e9c4116bd07bad5c9538451918a44923bf832915 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
@@ -45,7 +45,7 @@ public class TabularContextMenuUi implements ContextMenuUi, AdapterView.OnItemCl
private ContextMenuHelper mContextMenuHelper;
/**
- * A context menu that sperates types by tabs.
+ * A context menu that separates types by tabs.
* @param contextMenuHelper The {@link ContextMenuHelper} is used to retrieve the thumbnail
* natively from the Context Menu Helper.
*/
@@ -117,7 +117,7 @@ public class TabularContextMenuUi implements ContextMenuUi, AdapterView.OnItemCl
// Set the list adapter and get the height to display it appropriately in a dialog.
TabularContextMenuListAdapter listAdapter =
- new TabularContextMenuListAdapter(items, activity);
+ new TabularContextMenuListAdapter(items, activity, mContextMenuHelper);
ViewGroup.LayoutParams layoutParams = listView.getLayoutParams();
layoutParams.height = measureApproximateListViewHeight(listView, listAdapter, maxCount);
listView.setLayoutParams(layoutParams);

Powered by Google App Engine
This is Rietveld 408576698