Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3697)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

Issue 2775373002: Add a Share Icon to Tabular Context Menu (Closed)
Patch Set: Fixed more tests! Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java
index c73f44c85d8de2802279d7decb1ae010d6135b33..ed8b36eb4d3d71a6dd650787974d6f33bada7164 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.contextmenu;
+import android.app.Activity;
import android.content.Context;
import android.text.TextUtils;
import android.util.Pair;
@@ -26,12 +27,12 @@ public class PlatformContextMenuUi implements ContextMenuUi {
}
@Override
- public void displayMenu(Context context, ContextMenuParams params,
+ public void displayMenu(Activity activity, ContextMenuParams params,
List<Pair<Integer, List<ContextMenuItem>>> itemGroups, final Callback<Integer> listener,
Runnable onMenuShown, Runnable onMenuClosed) {
String headerText = ChromeContextMenuPopulator.createHeaderText(params);
if (!TextUtils.isEmpty(headerText)) {
- setHeaderText(context, mMenu, headerText);
+ setHeaderText(activity, mMenu, headerText);
}
MenuItem.OnMenuItemClickListener menuListener = new MenuItem.OnMenuItemClickListener() {
@@ -45,7 +46,7 @@ public class PlatformContextMenuUi implements ContextMenuUi {
List<ContextMenuItem> group = itemGroups.get(groupIndex).second;
for (int itemIndex = 0; itemIndex < group.size(); itemIndex++) {
ContextMenuItem item = group.get(itemIndex);
- MenuItem menuItem = mMenu.add(0, item.menuId, 0, item.getString(context));
+ MenuItem menuItem = mMenu.add(0, item.menuId, 0, item.getString(activity));
menuItem.setOnMenuItemClickListener(menuListener);
}
}

Powered by Google App Engine
This is Rietveld 408576698