chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java - Issue 2775373002: Add a Share Icon to Tabular Context Menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

Issue 2775373002: Add a Share Icon to Tabular Context Menu (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

index 0dbba5305a432afec2803c0b89273656cd6a64d7..914ebef149f5aba71b1d800eb9a59a78effe3fc9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

@@ -119,7 +119,7 @@ public class TabularContextMenuUi implements ContextMenuUi, AdapterView.OnItemCl

// Set the list adapter and get the height to display it appropriately in a dialog.

TabularContextMenuListAdapter listAdapter =

- new TabularContextMenuListAdapter(items, activity);

+ new TabularContextMenuListAdapter(items, activity, mContextMenuHelper);

ViewGroup.LayoutParams layoutParams = listView.getLayoutParams();

layoutParams.height = measureApproximateListViewHeight(listView, listAdapter, maxCount);

listView.setLayoutParams(layoutParams);