Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4791)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java

Issue 2775373002: Add a Share Icon to Tabular Context Menu (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
index 6f7f4ad22dcb4a2b2bd4f5d5383183bc385668f1..75b8a9531262812abd35b419cf08a6a0431dce6c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
@@ -5,6 +5,7 @@
package org.chromium.chrome.browser.contextmenu;
import android.app.Activity;
+import android.content.ComponentName;
import android.graphics.Bitmap;
import android.graphics.BitmapFactory;
import android.util.Pair;
@@ -39,6 +40,7 @@ public class ContextMenuHelper implements OnCreateContextMenuListener {
private Runnable mOnMenuShown;
private Runnable mOnMenuClosed;
private OnThumbnailReceivedListener mOnThumbnailReceivedListener;
+ private ComponentName mComponentName;
interface OnThumbnailReceivedListener {
void onThumbnailReceived(Bitmap bitmap);
@@ -167,7 +169,14 @@ public class ContextMenuHelper implements OnCreateContextMenuListener {
Activity activity = windowAndroid.getActivity().get();
if (activity == null) return;
- ShareHelper.shareImage(activity, jpegImageData);
+ ShareHelper.shareImage(activity, jpegImageData, mComponentName);
+ // Reset the component name so it can share otherwise.
Theresa 2017/03/27 21:17:43 This comment isn't very clear.
JJ 2017/03/27 23:23:09 Done.
+ mComponentName = null;
+ }
+
+ public void shareImageDirectly(ComponentName name) {
Theresa 2017/03/27 21:17:43 nit: this needs a JavaDoc.
JJ 2017/03/27 23:23:09 Done.
+ mComponentName = name;
+ shareImage();
}
public void getThumbnail() {

Powered by Google App Engine
This is Rietveld 408576698