Add a Share Icon to Tabular Context Menu

chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextmenu;
 
 import android.app.Activity;
-import android.content.Context;
+import android.content.ComponentName;
 import android.graphics.Bitmap;
 import android.graphics.BitmapFactory;
 import android.util.Pair;
 import android.view.ContextMenu;
 import android.view.ContextMenu.ContextMenuInfo;
 import android.view.View;
 import android.view.View.OnCreateContextMenuListener;
 
 import org.chromium.base.Callback;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.chrome.browser.ChromeFeatureList;
 import org.chromium.chrome.browser.share.ShareHelper;
 import org.chromium.content.browser.ContentViewCore;
 import org.chromium.content_public.browser.WebContents;
 import org.chromium.ui.base.WindowAndroid;
 import org.chromium.ui.base.WindowAndroid.OnCloseContextMenuListener;
 
 import java.util.List;
 
 /**
  * A helper class that handles generating context menus for {@link ContentViewCore}s.
  */
 public class ContextMenuHelper implements OnCreateContextMenuListener {
     private long mNativeContextMenuHelper;
 
     private ContextMenuPopulator mPopulator;
     private ContextMenuParams mCurrentContextMenuParams;
-    private Context mContext;
+    private Activity mActivity;

[Theresa, 2017/03/30 15:12:45]

Typically we recommend against caching the activity since a Tab's activity may
change if it's is reparented in Android N+ multiwindow mode. It looks like
mActivity gets reset every time showContextMenu() is called and the activity,
but it would be good to do a quick test:

1) Open Chrome, trigger the context menu
2) Put Chrome in multi-window mode
3) Move the tab that previously triggered the context menu to a new window (menu
-> "move to other window")
4) Trigger the context menu again and share item.

[JJ, 2017/03/30 16:20:17]

It works!

     private Callback<Integer> mCallback;
     private Runnable mOnMenuShown;
     private Runnable mOnMenuClosed;
     private OnThumbnailReceivedListener mOnThumbnailReceivedListener;
+    private ComponentName mComponentName;
 
     /**
      * This waits for a thumbnail to be retrieved by the native code.
      */
     interface OnThumbnailReceivedListener {
         /**
          * When the thumbnail is received it will send the thumbnail via this method. This is
          * activated after calling {@link #getThumbnail()}.
          * @param bitmap The bitmap that is retrieved from native code.
          */
@@ skipping 33 matching lines @@
      * @param contentViewCore The {@link ContentViewCore} to show the menu to.
      * @param params          The {@link ContextMenuParams} that indicate what menu items to show.
      */
     @CalledByNative
     private void showContextMenu(final ContentViewCore contentViewCore, ContextMenuParams params) {
         if (params.isFile()) return;
         View view = contentViewCore.getContainerView();
         final WindowAndroid windowAndroid = contentViewCore.getWindowAndroid();
 
         if (view == null || view.getVisibility() != View.VISIBLE || view.getParent() == null
-                || windowAndroid == null || windowAndroid.getContext().get() == null
+                || windowAndroid == null || windowAndroid.getActivity().get() == null
                 || mPopulator == null) {
             return;
         }
 
         mCurrentContextMenuParams = params;
-        mContext = windowAndroid.getContext().get();
+        mActivity = windowAndroid.getActivity().get();
         mCallback = new Callback<Integer>() {
             @Override
             public void onResult(Integer result) {
                 mPopulator.onItemSelected(
                         ContextMenuHelper.this, mCurrentContextMenuParams, result);
             }
         };
         mOnMenuShown = new Runnable() {
             @Override
             public void run() {
                 WebContents webContents = contentViewCore.getWebContents();
                 RecordHistogram.recordBooleanHistogram("ContextMenu.Shown", webContents != null);
             }
         };
         mOnMenuClosed = new Runnable() {
             @Override
             public void run() {
                 if (mNativeContextMenuHelper == 0) return;
                 nativeOnContextMenuClosed(mNativeContextMenuHelper);
             }
         };
 
         if (ChromeFeatureList.isEnabled(ChromeFeatureList.CUSTOM_CONTEXT_MENU)) {
             List<Pair<Integer, List<ContextMenuItem>>> items =
-                    mPopulator.buildContextMenu(null, mContext, mCurrentContextMenuParams);
+                    mPopulator.buildContextMenu(null, mActivity, mCurrentContextMenuParams);
 
             ContextMenuUi menuUi = new TabularContextMenuUi(this);
-            menuUi.displayMenu(mContext, mCurrentContextMenuParams, items, mCallback, mOnMenuShown,
+            menuUi.displayMenu(mActivity, mCurrentContextMenuParams, items, mCallback, mOnMenuShown,
                     mOnMenuClosed);
             return;
         }
 
         // The Platform Context Menu requires the listener within this hepler since this helper and
         // provides context menu for us to show.
         view.setOnCreateContextMenuListener(this);
         if (view.showContextMenu()) {
             mOnMenuShown.run();
             windowAndroid.addContextMenuCloseListener(new OnCloseContextMenuListener() {
@@ skipping 31 matching lines @@
         if (mNativeContextMenuHelper == 0) return;
         nativeShareImage(mNativeContextMenuHelper);
     }
 
     @CalledByNative
     private void onShareImageReceived(
             WindowAndroid windowAndroid, byte[] jpegImageData) {
         Activity activity = windowAndroid.getActivity().get();
         if (activity == null) return;
 
-        ShareHelper.shareImage(activity, jpegImageData);
+        ShareHelper.shareImage(activity, jpegImageData, mComponentName);
+        // This needs to be reset to null after a share. This way the next time a user shares an
+        // image it won't share with the last shared item unless explicitly told.

[Theresa, 2017/03/30 15:12:45]

nit: ...won't share with the last shared app...?

[JJ, 2017/03/30 16:20:17]

Done.

+        mComponentName = null;
     }
 
     /**
+     * Share image triggered with the current context menu directly with a specific app.
+     * @param name The app to share the image directly with.

[Theresa, 2017/03/30 15:12:45]

nit: The {@link ComponentName} of the app to share...

[JJ, 2017/03/30 16:20:17]

Done.

+     */
+    public void shareImageDirectly(ComponentName name) {
+        mComponentName = name;
+        shareImage();
+    }
+
+    /**
      * Gets the thumbnail of the current image that triggered the context menu.
      */
     public void getThumbnail() {
         if (mNativeContextMenuHelper == 0) return;
         nativeRetrieveHeaderThumbnail(mNativeContextMenuHelper);
     }
 
     @CalledByNative
     private void onHeaderThumbnailReceived(WindowAndroid windowAndroid, byte[] jpegImageData) {
         Bitmap bitmap = BitmapFactory.decodeByteArray(jpegImageData, 0, jpegImageData.length);
         if (mOnThumbnailReceivedListener != null) {
             mOnThumbnailReceivedListener.onThumbnailReceived(bitmap);
         }
     }
 
     @Override
     public void onCreateContextMenu(ContextMenu menu, View v, ContextMenuInfo menuInfo) {
         List<Pair<Integer, List<ContextMenuItem>>> items =
                 mPopulator.buildContextMenu(menu, v.getContext(), mCurrentContextMenuParams);
         ContextMenuUi menuUi = new PlatformContextMenuUi(menu);
-        menuUi.displayMenu(
-                mContext, mCurrentContextMenuParams, items, mCallback, mOnMenuShown, mOnMenuClosed);
+        menuUi.displayMenu(mActivity, mCurrentContextMenuParams, items, mCallback, mOnMenuShown,
+                mOnMenuClosed);
     }
 
     /**
      * Sets the listener for retrieving a thumbnail when calling {@link #getThumbnail()}.
      * @param listener The listener that will be called once a thumbnail is retrieved.
      */
     public void setOnThumbnailReceivedListener(OnThumbnailReceivedListener listener) {
         mOnThumbnailReceivedListener = listener;
     }
 
     /**
      * @return The {@link ContextMenuPopulator} responsible for populating the context menu.
      */
     @VisibleForTesting
     public ContextMenuPopulator getPopulator() {
         return mPopulator;
     }
 
     private native void nativeOnStartDownload(
             long nativeContextMenuHelper, boolean isLink, boolean isDataReductionProxyEnabled);
     private native void nativeSearchForImage(long nativeContextMenuHelper);
     private native void nativeShareImage(long nativeContextMenuHelper);
     private native void nativeOnContextMenuClosed(long nativeContextMenuHelper);
     private native void nativeRetrieveHeaderThumbnail(long nativeContextMenuHelper);
 }