Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: chrome/android/java/res/layout/tabular_context_menu_row.xml

Issue 2775373002: Add a Share Icon to Tabular Context Menu (Closed)
Patch Set: Fixed more tests! Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2017 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" 5 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
6 xmlns:tools="http://schemas.android.com/tools" 6 xmlns:tools="http://schemas.android.com/tools"
7 android:orientation="horizontal" 7 android:orientation="horizontal"
8 android:layout_width="match_parent" 8 android:layout_width="match_parent"
9 android:layout_height="wrap_content" 9 android:layout_height="wrap_content"
10 android:paddingStart="15dp" 10 android:paddingStart="15dp"
11 android:paddingEnd="15dp" 11 android:paddingEnd="15dp"
12 android:minHeight="40dp" 12 android:minHeight="40dp"
13 tools:ignore="UseCompoundDrawables"> 13 tools:ignore="UseCompoundDrawables">
14 <ImageView 14 <ImageView
15 android:id="@+id/context_menu_icon" 15 android:id="@+id/context_menu_icon"
16 android:layout_width="20dp" 16 android:layout_width="20dp"
17 android:layout_height="20dp" 17 android:layout_height="20dp"
18 android:layout_gravity="center_vertical" 18 android:layout_gravity="center_vertical"
19 android:contentDescription="@null" /> 19 android:contentDescription="@null" />
20 <TextView 20 <TextView
21 android:id="@+id/context_text" 21 android:id="@+id/context_text"
22 android:layout_width="0dp" 22 android:layout_width="0dp"
23 android:layout_height="wrap_content" 23 android:layout_height="wrap_content"
24 android:layout_gravity="center_vertical" 24 android:layout_gravity="center_vertical"
25 android:layout_marginStart="10dp" 25 android:layout_marginStart="10dp"
26 android:layout_weight="1" 26 android:layout_weight="1"
27 android:textSize="15sp" 27 android:textSize="15sp"
28 android:textColor="#dd000000" /> 28 android:textColor="#dd000000" />
29 <ImageView
30 android:id="@+id/context_menu_share_icon"
31 android:layout_width="20dp"
32 android:layout_height="20dp"
33 android:layout_gravity="center_vertical"
34 android:contentDescription="@null"
35 android:visibility="gone"/>
29 </LinearLayout> 36 </LinearLayout>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698