Add a Share Icon to Tabular Context Menu

chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextmenu;
 
 import android.app.Activity;
 import android.graphics.drawable.Drawable;
 import android.util.Pair;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.BaseAdapter;
 import android.widget.ImageView;
 import android.widget.TextView;
 
 import org.chromium.chrome.R;
+import org.chromium.chrome.browser.share.ShareHelper;
 
 import java.util.List;
 
 /**
  * Takes a list of {@link ContextMenuItem} and puts them in an adapter meant to be used within a
  * list view.
  */
 class TabularContextMenuListAdapter extends BaseAdapter {
     private final List<ContextMenuItem> mMenuItems;
     private final Activity mActivity;
+    private final ContextMenuHelper mContextMenuHelper;
 
     /**
      * Adapter for the tabular context menu UI
      * @param menuItems The list of items to display in the view.
      * @param activity Used to inflate the layout.
+     * @param contextMenuHelper Used to directly share an image through the icon.

[Theresa, 2017/03/27 21:17:43]

nit: ... through an icon.

[JJ, 2017/03/27 23:23:09]

Done.

      */
-    TabularContextMenuListAdapter(List<ContextMenuItem> menuItems, Activity activity) {
+    TabularContextMenuListAdapter(List<ContextMenuItem> menuItems, Activity activity,
+            ContextMenuHelper contextMenuHelper) {
         mMenuItems = menuItems;
         mActivity = activity;
+        mContextMenuHelper = contextMenuHelper;
     }
 
     @Override
     public int getCount() {
         return mMenuItems.size();
     }
 
     @Override
     public Object getItem(int position) {
         return mMenuItems.get(position);
@@ skipping 28 matching lines @@
         Pair<Drawable, String> iconPair = menuItem.getDrawableAndDescription(mActivity);
         viewHolder.mIcon.setImageDrawable(iconPair.first);
         if (iconPair.first != null) {
             viewHolder.mIcon.setVisibility(View.VISIBLE);
             viewHolder.mIcon.setContentDescription(iconPair.second);
         } else {
             viewHolder.mIcon.setVisibility(View.INVISIBLE);
             viewHolder.mIcon.setContentDescription(null);
         }
 
+        if (menuItem == ContextMenuItem.SHARE_IMAGE) {
+            final Pair<Drawable, CharSequence> shareInfo =
+                    ShareHelper.getShareableIconAndName(mActivity);
+            if (shareInfo.first != null) {
+                viewHolder.mShareIcon.setImageDrawable(shareInfo.first);
+                viewHolder.mShareIcon.setVisibility(View.VISIBLE);
+                viewHolder.mShareIcon.setContentDescription(mActivity.getString(
+                        R.string.accessibility_menu_share_via, iconPair.second));
+                viewHolder.mShareIcon.setOnClickListener(new View.OnClickListener() {
+                    @Override
+                    public void onClick(View view) {
+                        mContextMenuHelper.shareImageDirectly(
+                                ShareHelper.getLastShareComponentName());
+                    }
+                });
+            }
+        } else {
+            viewHolder.mShareIcon.setImageDrawable(null);
+            viewHolder.mShareIcon.setVisibility(View.GONE);

[Theresa, 2017/03/27 21:17:43]

You should just be able to set visibility to GONE without setting the image
drawable, on click listener and content description.

[JJ, 2017/03/27 23:23:09]

True. I'll change it so!

+            viewHolder.mShareIcon.setOnClickListener(null);
+            viewHolder.mShareIcon.setContentDescription(null);
+        }
+
         return convertView;
     }
 
     private static class ViewHolderItem {
         ImageView mIcon;
         TextView mText;
         ImageView mShareIcon;
     }
 }